[issue19887] Path.resolve() fails on complex symlinks

Philippe Fremy added the comment: Hi, This precise set of tests fails on Windows 7 on a NTFS partition (on revision c0b0e7aef360+ tip ), see below. The problem is probably minor (drive letter case). I won't be able to develop a fix myself, but I'll be happy to test one. cheers, Philippe

[issue19887] Path.resolve() fails on complex symlinks

Antoine Pitrou added the comment: Thanks a lot for the patch! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue19887] Path.resolve() fails on complex symlinks

Roundup Robot added the comment: New changeset 12a52186b4fd by Antoine Pitrou in branch 'default': Issue #19887: Improve the Path.resolve() algorithm to support certain symlink chains. http://hg.python.org/cpython/rev/12a52186b4fd -- nosy: +python-dev __

[issue19887] Path.resolve() fails on complex symlinks

Antoine Pitrou added the comment: Ah, I remember. Using subtests would make it more annoying to backport to 2.7. -- ___ Python tracker ___ ___

[issue19887] Path.resolve() fails on complex symlinks

Antoine Pitrou added the comment: > why you repeat similar code 3-4 times instead using loops? For no real reason :) I'll try with a loop. -- ___ Python tracker ___

[issue19887] Path.resolve() fails on complex symlinks

Vajrasky Kok added the comment: The patch passed on Windows Vista. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue19887] Path.resolve() fails on complex symlinks

Serhiy Storchaka added the comment: > I suppose that was some kind of joke, but what I meant was that we don't need > to test with 100 levels of symlinks. 2 or 3 are enough... Yes, sorry for this joke. Your tests LGTM, but why you repeat similar code 3-4 times instead using loops? --

[issue19887] Path.resolve() fails on complex symlinks

Antoine Pitrou added the comment: Here is a patch with refactored tests. Vajrasky, do you want to test under Windows? -- Added file: http://bugs.python.org/file33156/pathlib_resolve_4.patch ___ Python tracker

[issue19887] Path.resolve() fails on complex symlinks

Antoine Pitrou added the comment: > Here is a patch with unrolled loops. I suppose that was some kind of joke, but what I meant was that we don't need to test with 100 levels of symlinks. 2 or 3 are enough... -- ___ Python tracker

[issue19887] Path.resolve() fails on complex symlinks

Changes by Serhiy Storchaka : -- assignee: -> pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue19887] Path.resolve() fails on complex symlinks

Serhiy Storchaka added the comment: Here is a patch with unrolled loops. -- Added file: http://bugs.python.org/file33024/pathlib_resolve_3.patch ___ Python tracker ___ __

[issue19887] Path.resolve() fails on complex symlinks

Vajrasky Kok added the comment: And don't forget to use self.dirlink instead of os.symlink(src, dst, target_is_directory=True). -- ___ Python tracker ___ ___

[issue19887] Path.resolve() fails on complex symlinks

Antoine Pitrou added the comment: > How the test can be simpler? It is already simple. I mean, don't use loops but a simple test setup as in test_resolve_dot. I am not interested in the pathologic "100 symlinks" case, just the case where the symlink is absolute. -- ___

[issue19887] Path.resolve() fails on complex symlinks

Changes by Serhiy Storchaka : -- title: Path.resolve() ENAMETOOLONG on pathologic symlinks -> Path.resolve() fails on complex symlinks ___ Python tracker ___ ___