[issue19802] socket.SO_PRIORITY is missing

2016-06-28 Thread Larry Hastings
Larry Hastings added the comment: Sorry, this is now too late for 3.4. 3.4 is now in "security fixes only" mode. This is not a security fix, therefore 3.4 is now ineligible. Since this change was committed to 3.5, it's better to let the historical record reflect that. So I'm changing the ve

[issue19802] socket.SO_PRIORITY is missing

2016-06-28 Thread Martin Panter
Changes by Martin Panter : -- versions: +Python 3.4 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19802] socket.SO_PRIORITY is missing

2013-11-27 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9bbada125b3f by Benjamin Peterson in branch 'default': add SO_PRIORITY (closes #19802) http://hg.python.org/cpython/rev/9bbada125b3f -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: open -> closed ___

[issue19802] socket.SO_PRIORITY is missing

2013-11-27 Thread Larry Hastings
Larry Hastings added the comment: It's *possible* but I'm willing to risk it. You have my permission to apply that patch. -- ___ Python tracker ___

[issue19802] socket.SO_PRIORITY is missing

2013-11-27 Thread STINNER Victor
STINNER Victor added the comment: You should also modify Doc/library/socket.rst to mention the new constant in the documentation (don't forget the ".. versionadded::" flag). Adding a new constant cannot break anything in Python, so I propose to it in Python 3.4. @Larry (our release manager):

[issue19802] socket.SO_PRIORITY is missing

2013-11-27 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19802] socket.SO_PRIORITY is missing

2013-11-26 Thread Vajrasky Kok
Vajrasky Kok added the comment: I agree. The test is not that meaningful. But hey, we have the test that tests this kind of constant. http://hg.python.org/cpython/rev/513da56d28de -- nosy: +vajrasky ___ Python tracker

[issue19802] socket.SO_PRIORITY is missing

2013-11-26 Thread R. David Murray
R. David Murray added the comment: Yeah, I'm not sure how you'd write a test in such a way that it would test anything meaningful. Parse the .h file in the test? Seems like overkill. -- ___ Python tracker __

[issue19802] socket.SO_PRIORITY is missing

2013-11-26 Thread Claudiu.Popa
Claudiu.Popa added the comment: Here's a simple patch which adds this flag. It has no tests, because I noticed that there are no tests for per-platform flags in test_socket.py (only for CAN, RDS and general flags). -- keywords: +patch nosy: +Claudiu.Popa Added file: http://bugs.python.

[issue19802] socket.SO_PRIORITY is missing

2013-11-26 Thread R. David Murray
R. David Murray added the comment: For the record, a little googling indicates this may be a linux-only option (FreeBSD 6.4, for example, does not support it, nor does OS X 10.8, which are two systems to which I currently have access). That doesn't mean it shouldn't be added. -- comp

[issue19802] socket.SO_PRIORITY is missing

2013-11-26 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- keywords: +easy versions: +Python 3.5 -Python 2.7, Python 3.3 ___ Python tracker ___ ___ Python-bugs

[issue19802] socket.SO_PRIORITY is missing

2013-11-26 Thread Sworddragon
New submission from Sworddragon: socket(7) does contain SO_PRIORITY but trying to use this value will result in this error: AttributeError: 'module' object has no attribute 'SO_PRIORITY' -- components: Library (Lib) messages: 204506 nosy: Sworddragon priority: normal severity: normal st