[issue19788] Always run kill_python(_d).exe when (re-)building on Windows

2013-11-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset ca600150205a by Zachary Ware in branch '3.3': Issue #19788: kill_python(_d).exe is now run as a PreBuildEvent on the http://hg.python.org/cpython/rev/ca600150205a New changeset 2c1e041cb504 by Zachary Ware in branch 'default': Issue #19788: kill_pyt

[issue19788] Always run kill_python(_d).exe when (re-)building on Windows

2013-11-26 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the test, Tim :) -- assignee: -> zach.ware resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue19788] Always run kill_python(_d).exe when (re-)building on Windows

2013-11-25 Thread Tim Peters
Tim Peters added the comment: Done. I wasn't able to provoke the failing test into leaving behind rogue processes, so I eventually just ran some python_d processes of my own. Of course that stopped the build from replacing the executables, so test_concurrent_futures kept failing. But after

[issue19788] Always run kill_python(_d).exe when (re-)building on Windows

2013-11-25 Thread Tim Peters
Tim Peters added the comment: OK, looked at the code and sees that it tries to kill only pythons created by the build process - I feel batter now :-) -- ___ Python tracker ___ _

[issue19788] Always run kill_python(_d).exe when (re-)building on Windows

2013-11-25 Thread Tim Peters
Tim Peters added the comment: Zach, I'll try the patch soon. Will this kill _all_ Python processes? I often have some unrelated Python program(s) running when waiting for a development build to finish, so that could create real havoc. BTW, I'm sure you're right that zombie Pythons were the c

[issue19788] Always run kill_python(_d).exe when (re-)building on Windows

2013-11-25 Thread Zachary Ware
New submission from Zachary Ware: The attached patch turns running kill_python(_d).exe into a PreBuildEvent in pythoncore.vcxproj. This should guarantee that kill_python(_d).exe is always run to guarantee no zombie pythons in the background can prevent overwriting the Python dll. The pythonc