[issue19636] Fix usage of MAX_PATH in posixmodule.c

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed versions: +Python 3.4 ___ Python tracker ___ ___ Python-bu

[issue19636] Fix usage of MAX_PATH in posixmodule.c

Roundup Robot added the comment: New changeset b3eb42a657a3 by Victor Stinner in branch 'default': Issue #19636: Fix posix__getvolumepathname(), raise an OverflowError if http://hg.python.org/cpython/rev/b3eb42a657a3 New changeset 46aecfc5e374 by Victor Stinner in branch 'default': Issue #19636:

[issue19636] Fix usage of MAX_PATH in posixmodule.c

Tim Golden added the comment: Fine with your volumepathname patch. The core of the code was contributed and I didn't check it too carefully as it clearly worked. (For some definition of "worked"). -- ___ Python tracker

[issue19636] Fix usage of MAX_PATH in posixmodule.c

STINNER Victor added the comment: Oh, I forgot to mention that my initial concern was the following warning: ..\Modules\posixmodule.c(4057): warning C4267: 'function' : conversion from 'size_t' to 'DWORD', possible loss of data [C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\pythoncore

[issue19636] Fix usage of MAX_PATH in posixmodule.c

Changes by STINNER Victor : -- nosy: +tim.golden ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue19636] Fix usage of MAX_PATH in posixmodule.c

STINNER Victor added the comment: posix__getfullpathname(): -char outbuf[MAX_PATH*2]; +char outbuf[MAX_PATH]; ... -wchar_t woutbuf[MAX_PATH*2], *woutbufp = woutbuf; +wchar_t woutbuf[MAX_PATH], *woutbufp = woutbuf; I don't know what "*2" was used here, probably a mistake

[issue19636] Fix usage of MAX_PATH in posixmodule.c

New submission from STINNER Victor: The length of a path is not always correctly handled in posixmodule.c, the worst case is posix__getvolumepathname() which pass a length two times smaller than the buffer (GetVolumePathNameW() expects a number of WCHAR characters, not a number of bytes). MAX