[issue19633] test_wave: failures on PPC64 buildbot

2013-11-21 Thread STINNER Victor
STINNER Victor added the comment: "PPC64 PowerLinux 3.x" buildbot is green again! I'm closing the issue. I didn't check 2.7 and 3.3 buildbots. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7b040bc289e8 by Serhiy Storchaka in branch '3.3': Issue #19633: Fixed writing not compressed 16- and 32-bit wave files on http://hg.python.org/cpython/rev/7b040bc289e8 New changeset 7cf7f19445ba by Serhiy Storchaka in branch 'default': Issue #19633:

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-19 Thread David Edelsohn
David Edelsohn added the comment: By the way, test_wave also fails on zLinux, which also is Big Endian. -- ___ Python tracker ___ ___

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > If the file is truncated, why would the test suceed on little endian? The > file doesn't have the same size in bytes? The test doesn't check the number > of frames? Because this code is not used on little endian. On little endian a data is read by file's re

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: > Because array.fromfile() is used only to swap 16- and 32-bit samples on > bigendian platform. If the file is truncated, why would the test suceed on little endian? The file doesn't have the same size in bytes? The test doesn't check the number of frames? -

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Why the test succeeded on little endian? Because array.fromfile() is used only to swap 16- and 32-bit samples on bigendian platform. Perhaps we need the byteswap() function in the audioop module. -- ___ Python

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: > array's constructor interprets its second memoryview argument as an iterable > of integers. Ok so, so your fix is correct. > First patch fixes only a half of the issue. > test_unseekable_incompleted_write() still failed because array.fromfile() > fails rea

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: array's constructor interprets its second memoryview argument as an iterable of integers. >>> import array >>> array.array('h', b'abcd') array('h', [25185, 25699]) >>> array.array('h', memoryview(b'abcd')) array('h', [97, 98, 99, 100]) array.frombytes() alwa

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-17 Thread David Edelsohn
Changes by David Edelsohn : -- nosy: +David.Edelsohn ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your report. This patch should fix the issue. -- components: +Library (Lib) -Tests keywords: +patch stage: -> patch review type: -> behavior Added file: http://bugs.python.org/file32674/wave_byteswap.patch

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-17 Thread STINNER Victor
New submission from STINNER Victor: Some test_wave are failing, but only on PPC64 (big endian, right?). It may be related to issue #1575020. http://buildbot.python.org/all/builders/PPC64%20PowerLinux%203.x/builds/1099/steps/test/logs/stdio =