[issue19596] Silently skipped tests in test_importlib

2013-11-18 Thread Zachary Ware
Zachary Ware added the comment: Committed in 3.3 and as 5d38989191bb in features/pep-451. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue19596] Silently skipped tests in test_importlib

2013-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1ac4f0645519 by Zachary Ware in branch '3.3': Issue #19596: Set untestable tests in test_importlib to None http://hg.python.org/cpython/rev/1ac4f0645519 New changeset 34a65109d191 by Zachary Ware in branch 'default': Issue #19596: Null merge with 3.

[issue19596] Silently skipped tests in test_importlib

2013-11-18 Thread Zachary Ware
Zachary Ware added the comment: Alright, I'll try to do that later this evening. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue19596] Silently skipped tests in test_importlib

2013-11-18 Thread Brett Cannon
Brett Cannon added the comment: I've actually started doing this in the PEP 451 repo and it's working out so far. When that all lands I should have all the loaders ported but not the finders. If you want, Zachary, you can make the chances in the PEP 451 repo so you don't have to wonder what ha

[issue19596] Silently skipped tests in test_importlib

2013-11-17 Thread Zachary Ware
Zachary Ware added the comment: How does this one strike you, Brett? Setting the empty tests to None seems to keep the ABC happy and reduces the total number of tests from 632 to 598. -- Added file: http://bugs.python.org/file32679/skipped_importlib_tests.v2.diff _

[issue19596] Silently skipped tests in test_importlib

2013-11-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Agreed with both Brett and Serhiy. -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mail

[issue19596] Silently skipped tests in test_importlib

2013-11-15 Thread Brett Cannon
Brett Cannon added the comment: As long as setting them to None satisfies the ABC that's fine with me. -- ___ Python tracker ___ ___ P

[issue19596] Silently skipped tests in test_importlib

2013-11-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In this case we should do test_package = None # Built-in modules cannot be a package. test_module_in_package = None # Built-in modules cannobt be in a package. ... And then tests will be skipped and not shown in test report. -- _

[issue19596] Silently skipped tests in test_importlib

2013-11-15 Thread Brett Cannon
Brett Cannon added the comment: These tests can't be removed because the classes are inheriting from an ABC to make sure that those test cases are considered and dealt with, either by explicitly testing them or ignoring them because they don't apply to the finder/loader. And since they are be

[issue19596] Silently skipped tests in test_importlib

2013-11-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I use `test_spam = None` to skip the test in a subclass and remove it from the report. The question is which of these tests should be removed because they are senseless in specified subclass and which of them are just not implemented yet and should be repor

[issue19596] Silently skipped tests in test_importlib

2013-11-14 Thread Zachary Ware
New submission from Zachary Ware: Several tests in test_importlib are skipped by way of the test method consisting of a comment and a 'pass' statement. The attached patch makes the skips explicit, using the removed comment as the reason. Ideally these skipped tests should be removed from bei