[issue19587] Remove empty tests in test_bytes.FixedStringTest

2016-02-01 Thread Martin Panter
Martin Panter added the comment: Thanks Serhiy for reviewing. You are right that buffer_tests is only run on bytearray; I must have gotten mixed up. I fixed the comment in the version I committed. Yes I think I agree with eliminating buffer_tests.py, which is only run for bytearray. I opened

[issue19587] Remove empty tests in test_bytes.FixedStringTest

2016-02-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 22c2dd04a3d3 by Martin Panter in branch '3.5': Issue #19587: Remove masked and redundant tests in test_bytes https://hg.python.org/cpython/rev/22c2dd04a3d3 New changeset 8545a082fcaa by Martin Panter in branch 'default': Issue #19587: Merge test_byt

[issue19587] Remove empty tests in test_bytes.FixedStringTest

2015-12-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Currently buffer_tests.py is used only for bytearray, and it looks that it duplicates string_tests.py. May be remove all duplicated tests and move the rest of tests (if any) just into test_bytes.py? -- ___ Python

[issue19587] Remove empty tests in test_bytes.FixedStringTest

2015-12-17 Thread Martin Panter
Martin Panter added the comment: test_contains() does not appear to be overriding anything, so there is no problem removing that. Unmasking the other three methods will allow six new test methods to run (via ByteArrayAsStringTest and BytesAsStringTest). There are already three equivalent meth

[issue19587] Remove empty tests in test_bytes.FixedStringTest

2013-11-16 Thread Ezio Melotti
Ezio Melotti added the comment: I said this elsewhere but I'll repeat it here. I think the whole string_tests could/should be reorganized (and possibly documented). There are lot of classes and mixins on several files, and more than once I found tests that were accidentally not run or had othe

[issue19587] Remove empty tests in test_bytes.FixedStringTest

2013-11-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This LGTM, but the purpose of suppressing these tests is not absolutely clear to me. I suppose they were suppressed in times when bytes and batearray had no the lower() and upper() methods and the __contains__() methods accepted only integers. It will be goo

[issue19587] Remove empty tests in test_bytes.FixedStringTest

2013-11-14 Thread Zachary Ware
Changes by Zachary Ware : -- title: Remove test_bytes.FixedStringTest -> Remove empty tests in test_bytes.FixedStringTest ___ Python tracker ___