[issue19505] OrderedDict views don't implement __reversed__

2014-04-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Done. Thank you Raymond for your review. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue19505] OrderedDict views don't implement __reversed__

2014-04-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset cee010fecdf5 by Serhiy Storchaka in branch 'default': Issue #19505: The items, keys, and values views of OrderedDict now support http://hg.python.org/cpython/rev/cee010fecdf5 -- nosy: +python-dev ___ Pyth

[issue19505] OrderedDict views don't implement __reversed__

2014-04-02 Thread Raymond Hettinger
Raymond Hettinger added the comment: This is approved. Go ahead and apply the patch. One minor nit, please position the three new views classes before the _Link class rather than after. -- assignee: rhettinger -> serhiy.storchaka versions: +Python 3.5 -Python 3.4

[issue19505] OrderedDict views don't implement __reversed__

2013-11-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: We can't add __reversed__() to the Set or MappingView protocols without breaking third party code, but we can add it to concrete implementations of mapping views. In particular for views of OrderedDict which itself already have __reversed__(). Here is a pat

[issue19505] OrderedDict views don't implement __reversed__

2013-11-06 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- priority: normal -> low type: -> enhancement versions: -Python 2.7, Python 3.3 ___ Python tracker ___

[issue19505] OrderedDict views don't implement __reversed__

2013-11-05 Thread Eric Snow
Eric Snow added the comment: The view objects aren't sequences. od.items() and od.keys() implement Set. od.values() doesn't even do that much, only implementing __len__(), __iter__(), and __contains__(). The glossary implies that you should use "reversed(list(view))". [1] More information

[issue19505] OrderedDict views don't implement __reversed__

2013-11-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka, stutzbach versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2 ___ Python tracker ___ _

[issue19505] OrderedDict views don't implement __reversed__

2013-11-05 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19505] OrderedDict views don't implement __reversed__

2013-11-05 Thread ThiefMaster
New submission from ThiefMaster: The view objects for `collections.OrderedDict` do not implement `__reversed__` so something like this fails: >>> from collections import OrderedDict >>> od = OrderedDict() >>> reversed(od.viewvalues()) Traceback (most recent call last): Fil