[issue19418] audioop.c giving signed/unsigned warnings on Windows

STINNER Victor added the comment: New changeset e5b79c546370521764457ea2ec809303e580f5ea by Victor Stinner in branch '2.7': bpo-19418: audioop.c: Fix warnings on -0x8000 (GH-7453) https://github.com/python/cpython/commit/e5b79c546370521764457ea2ec809303e580f5ea -- _

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Change by STINNER Victor : -- pull_requests: +7075 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Tim Golden added the comment: Fixed in 3.3 / 3.4 -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed versions: -Python 2.7 ___ Python tracker

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Roundup Robot added the comment: New changeset 54bf7b5ec3b6 by Tim Golden in branch '3.3': Issue #19418 Fix some warnings on Win64 http://hg.python.org/cpython/rev/54bf7b5ec3b6 -- ___ Python tracker ___

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Roundup Robot added the comment: New changeset 0848c90a5dd1 by Tim Golden in branch 'default': Issue #19418 Fix some warnings on Win64 http://hg.python.org/cpython/rev/0848c90a5dd1 -- nosy: +python-dev ___ Python tracker

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Serhiy Storchaka added the comment: LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Changes by Tim Golden : Removed file: http://bugs.python.org/file32400/issue19418.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Tim Golden added the comment: Good point. Updated patch. -- Added file: http://bugs.python.org/file32401/issue19418.2.diff ___ Python tracker ___

[issue19418] audioop.c giving signed/unsigned warnings on Windows

STINNER Victor added the comment: You should add a comment to explain why the trick is required (because of compilers not supporting -0x8000 literal without a warning). -- nosy: +haypo ___ Python tracker _

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Tim Golden added the comment: The attached patch (using Tim Peters' -1 trick) builds & tests ok on Win32/64 & Linux 32. -- Added file: http://bugs.python.org/file32400/issue19418.diff ___ Python tracker __

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Changes by Tim Golden : Removed file: http://bugs.python.org/file32390/audioop.diff ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Tim Golden added the comment: Good idea. I'll test against Win32/64 & Linux 32 -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Tim Peters added the comment: @Serhiy, nope, pressed for time today :-( -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Serhiy Storchaka added the comment: LGTM. Do you want commit a patch? -- stage: -> commit review versions: +Python 2.7, Python 3.3 ___ Python tracker ___ ___

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Tim Peters added the comment: Use -0x7FFF-1 Nobody should complain about that, because it's standard C ;-) On Sun, Oct 27, 2013 at 3:20 PM, Tim Golden wrote: > > Tim Golden added the comment: > > I don't think it will, given MS description of the compiler warning: > > http://msdn.microsof

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Tim Golden added the comment: I don't think it will, given MS description of the compiler warning: http://msdn.microsoft.com/en-us/library/4kh09110%28v=vs.100%29.aspx but I'll certainly give it a go. -- ___ Python tracker

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Serhiy Storchaka added the comment: What if use (int)-0x8000 instead of -(int)0x8000? Does it silence warnings on Windows? -- ___ Python tracker ___

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Serhiy Storchaka added the comment: But it adds warnings on 32-bit platform with GCC. /home/serhiy/py/cpython/Modules/audioop.c:18:61: warning: integer overflow in expression [-Woverflow] /home/serhiy/py/cpython/Modules/audioop.c: In function ‘audioop_minmax’: /home/serhiy/py/cpython/Modules/au

[issue19418] audioop.c giving signed/unsigned warnings on Windows

Tim Golden added the comment: The attached patch appears to fix the problem. -- keywords: +patch Added file: http://bugs.python.org/file32390/audioop.diff ___ Python tracker ___

[issue19418] audioop.c giving signed/unsigned warnings on Windows

New submission from Tim Golden: Modules/audioop.c is giving compile warnings on Windows against lines 18 & 437. ..\Modules\audioop.c(18): warning C4146: unary minus operator applied to unsigned type, result still unsigned ..\Modules\audioop.c(437): warning C4146: unary minus operator applied to