[issue19358] Integrate "Argument Clinic" into CPython build

Larry Hastings added the comment: Fixed. By the way, this checkin also added a tiny new feature to Argument Clinic: if the file hasn't changed, it doesn't bother to rewrite it (or touch it in any way). -- assignee: -> larry resolution: -> fixed stage: patch review -> commit review s

[issue19358] Integrate "Argument Clinic" into CPython build

Roundup Robot added the comment: New changeset 29370c25e0f1 by Larry Hastings in branch 'default': Issue #19358: "make clinic" now runs the Argument Clinic preprocessor http://hg.python.org/cpython/rev/29370c25e0f1 -- nosy: +python-dev ___ Python trac

[issue19358] Integrate "Argument Clinic" into CPython build

Larry Hastings added the comment: (Whoops, forgot to attach the new diff.) -- Added file: http://bugs.python.org/file32788/larry.make.clinic.patch.2.diff ___ Python tracker ___ _

[issue19358] Integrate "Argument Clinic" into CPython build

Larry Hastings added the comment: Okay, there's more than one way to skin this cat. This version uses os.walk(). -- ___ Python tracker ___ __

[issue19358] Integrate "Argument Clinic" into CPython build

STINNER Victor added the comment: + $(RUNSHARED) $(PYTHON_FOR_BUILD) ./Tools/clinic/clinic.py */*.c There are deeper directories containing .c files: Mac/Tools, Modules/cjkcodecs, Modules/_ctypes, Modules/_decimal, Modules/expat, ./PC/bdist_wininst, etc. -- _

[issue19358] Integrate "Argument Clinic" into CPython build

Larry Hastings added the comment: Attached is a patch to at least add a "make clinic" target for the UNIX-like platforms. This doesn't add anything for the Windows build. -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file32786/larry.make.clinic.patch.1.

[issue19358] Integrate "Argument Clinic" into CPython build

Larry Hastings added the comment: For a long time it was actually 3.4+ only. I was depending on a particular AST node that wasn't exposed to Python until 3.4 trunk. But that went away, and I tried it with 3.3 and it worked fine, so I labeled it 3.3+. For all I know it works fine under 3.1,

[issue19358] Integrate "Argument Clinic" into CPython build

Antoine Pitrou added the comment: > Patches welcome! I have bigger fish to fry. That doesn't solve the "why" question. You wrote the code and it probably takes you two minutes to make a fix. -- ___ Python tracker

[issue19358] Integrate "Argument Clinic" into CPython build

Larry Hastings added the comment: > Well, why is clinic 3.3 only? It would be slightly easier > if it accepted any "python3" executable. Patches welcome! I have bigger fish to fry. -- ___ Python tracker _

[issue19358] Integrate "Argument Clinic" into CPython build

Antoine Pitrou added the comment: > > Well, I don't really know how to do it. You'd have to have a step > > that somehow scans for .c files in the source tree, looks for > > clinic headers and compute whether they're outdated? > > Does it really need to be automated? We may only regenerate clini

[issue19358] Integrate "Argument Clinic" into CPython build

STINNER Victor added the comment: > Well, I don't really know how to do it. You'd have to have a step that > somehow scans for .c files in the source tree, looks for clinic headers and > compute whether they're outdated? Does it really need to be automated? We may only regenerate clinic things

[issue19358] Integrate "Argument Clinic" into CPython build

Antoine Pitrou added the comment: Well, why is clinic 3.3 only? It would be slightly easier if it accepted any "python3" executable. -- ___ Python tracker ___ __

[issue19358] Integrate "Argument Clinic" into CPython build

Larry Hastings added the comment: I thought it'd be more like, write a special C program that probes to see if you have a built python in the current directory, and if not looks on the path for a python3 (>=3.3), and if it finds a python it can use it runs Clinic on its arguments. Then make s

[issue19358] Integrate "Argument Clinic" into CPython build

Antoine Pitrou added the comment: Well, I don't really know how to do it. You'd have to have a step that somehow scans for .c files in the source tree, looks for clinic headers and compute whether they're outdated? (but this must only be done if the .c files are younger than the .o files, i.e.

[issue19358] Integrate "Argument Clinic" into CPython build

Larry Hastings added the comment: Drat! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue19358] Integrate "Argument Clinic" into CPython build

Changes by Antoine Pitrou : -- assignee: pitrou -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19358] Integrate "Argument Clinic" into CPython build

New submission from Larry Hastings: Somebody needs to figure out how to best integrate Argument Clinic into the build. Antoine, I think you said it sounded like... "fun"? Maybe? Anyway, I'm hoping you're willing to take a stab at it. If not please assign the issue back to nobody, and sorry