[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your contribution Arfrever. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed type: -> behavior ___ Python tracker

[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 61ab0c6907f9 by Serhiy Storchaka in branch '3.3': Issue #19287: Fixed the "in" operator of dbm.ndbm databases for string http://hg.python.org/cpython/rev/61ab0c6907f9 New changeset cb82b4efa67b by Serhiy Storchaka in branch 'default': Issue #19287:

[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. Could you please sign a contributor agreement ([1], [2]) Arfrever? [1] http://www.python.org/psf/contrib/ [2] http://www.python.org/psf/contrib/contrib-form/ -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka priority: release blocker ->

[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-19 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +georg.brandl, larry priority: normal -> release blocker ___ Python tracker ___

[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-19 Thread Berker Peksag
Berker Peksag added the comment: > What about dbm.dumb? dbm.dumb works fine with str: $ python3.3 -c 'from dbm import dumb; db=dumb.open("/tmp/db2", "c"); db["key"]="value"; print(b"key" in db); print("key" in db)' True True $ ./python -c 'from dbm import dumb; db=dumb.open("/tmp/db2", "c");

[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-19 Thread Vajrasky Kok
Vajrasky Kok added the comment: Sorry, I just found out that you already created a separate ticket for dbm.gnu. http://bugs.python.org/issue19288 What about dbm.dumb? -- ___ Python tracker ___

[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-19 Thread Vajrasky Kok
Vajrasky Kok added the comment: What about dbm.gnu and dbm.dumb? Should we add string key support as well? -- nosy: +vajrasky ___ Python tracker ___ _

[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-18 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- keywords: +easy stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-18 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- keywords: +patch Added file: http://bugs.python.org/file32214/issue19287.patch ___ Python tracker ___

[issue19287] __contains__() of dbm.ndbm databases fails with str

2013-10-18 Thread Arfrever Frehtes Taifersar Arahesis
New submission from Arfrever Frehtes Taifersar Arahesis: __contains__() of dbm.ndbm databases fails with str, probably since 8beaa9a37387. This is a regression in Python 3.3. $ python3.2 -c 'import dbm.ndbm; db=dbm.ndbm.open("/tmp/db1", "c"); db["key"]="value"; print(b"key" in db); print("key