[issue19232] Speed up _decimal import

Roundup Robot added the comment: New changeset 75b5617b8dfc by Stefan Krah in branch 'default': Issue #19232: Fix sys.modules lookup (--without-threads) https://hg.python.org/cpython/rev/75b5617b8dfc -- ___ Python tracker

[issue19232] Speed up _decimal import

Stefan Krah added the comment: I'm fine with closing this. The structseq issue is #1820. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.5 -Python 3.4 ___ Python tracker

[issue19232] Speed up _decimal import

STINNER Victor added the comment: "We could speed up the import further by not importing collections in _decimal. That could be done once structseq fully implements the namedtuple protocol (for DecimalTuple)." I suggest to close this issue. I guess that importing decimal is already fast enough

[issue19232] Speed up _decimal import

Stefan Krah added the comment: We could speed up the import further by not importing collections in _decimal. That could be done once structseq fully implements the namedtuple protocol (for DecimalTuple). -- ___ Python tracker

[issue19232] Speed up _decimal import

Roundup Robot added the comment: New changeset 8bf51cf94405 by Stefan Krah in branch 'default': Issue #19232: Speed up decimal import. Additionally, since _decimal is http://hg.python.org/cpython/rev/8bf51cf94405 -- nosy: +python-dev ___ Python track

[issue19232] Speed up _decimal import

Stefan Krah added the comment: I would like to go ahead with this. As Antoine mentioned, most people don't diagnose import problems, especially when they compare Python 2 against Python 3. As it turns out, the slowdown is even significant in a simple tcpserver application that starts a Python s

[issue19232] Speed up _decimal import

Antoine Pitrou added the comment: > OTOH I don't like moving code around either, so we can wait until > there's a demonstrated need for the speedup. Keep in mind that people who have startup speed problems aren't likely to open an issue on the tracker about it, let alone diagnose it enough to pu

[issue19232] Speed up _decimal import

Stefan Krah added the comment: About IDLE I can't say anything, but I'm not entirely sure if the PEP-399 import method is easier to understand for users, see e.g.: http://stackoverflow.com/questions/13194384/instantiate-decimal-class I get the impression that the posters at first did not even r

[issue19232] Speed up _decimal import

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue19232] Speed up _decimal import

Raymond Hettinger added the comment: I think we should save these sort of tricks only for modules imported during startup. Ideally, a user should expect that the code for the decimal module is in decimal.py. Ideally, tools like IDLE's "Open Module" should be able to find the source code usin

[issue19232] Speed up _decimal import

Stefan Krah added the comment: Antoine Pitrou wrote: > You can apply it using "hg import --no-commit", I think. mercurial 2.1 throws an exception even though the patch was created with that version. Now I upgraded to 2.7.2 and it works. Rietveld also seems to choke on the first patch (no revi

[issue19232] Speed up _decimal import

Mark Dickinson added the comment: > Mark, Raymond: Would you support the change (__name__ hack and all)? No objections here. -- ___ Python tracker ___ __

[issue19232] Speed up _decimal import

Antoine Pitrou added the comment: > I can't apply the patch that was created with diff --git, so here is > another one that is less readable but applies. You can apply it using "hg import --no-commit", I think. -- nosy: +pitrou ___ Python tracker

[issue19232] Speed up _decimal import

Stefan Krah added the comment: I can't apply the patch that was created with diff --git, so here is another one that is less readable but applies. -- Added file: http://bugs.python.org/file32066/issue19232-2.patch ___ Python tracker

[issue19232] Speed up _decimal import

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19232] Speed up _decimal import

Stefan Krah added the comment: _decimal already lies about its name (for pickling). -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue19232] Speed up _decimal import

STINNER Victor added the comment: > The other thing is that traditionally the types were "decimal.Decimal" > etc., so I'm not sure if it is good idea to have "_decimal.Decimal" and > "_pydecimal.Decimal". Why not renaming the _decimal module to decimal? -- _

[issue19232] Speed up _decimal import

Stefan Krah added the comment: I guess if some of the pickling stuff get's rewritten, we can drop __name__. The other thing is that traditionally the types were "decimal.Decimal" etc., so I'm not sure if it is good idea to have "_decimal.Decimal" and "_pydecimal.Decimal". Of course adding __mod

[issue19232] Speed up _decimal import

STINNER Victor added the comment: If the Python implementation is renamed to _pydecimal, I don't expect it to be used in CPython. I never used _pyio in a real application, only for some tests to debug. I don't think that we need the __name__ = 'decimal' "hack". If you really want to keep it, p

[issue19232] Speed up _decimal import

Changes by Stefan Krah : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19232] Speed up _decimal import

Stefan Krah added the comment: Right, let's start collecting objections. :) Mark, Raymond: Would you support the change (__name__ hack and all)? Maciej: Is this approach a problem for PyPy? -- nosy: +fijall, mark.dickinson, rhettinger ___ Python tr

[issue19232] Speed up _decimal import

Changes by Stefan Krah : -- keywords: +patch Added file: http://bugs.python.org/file32060/issue19232.diff ___ Python tracker ___ ___ P

[issue19232] Speed up _decimal import

Eric V. Smith added the comment: Remember that one reason for importing the C version at the bottom of the python version is so that alternate implementations (PyPy, IronPython, Jython) could provide partial versions of the C (or equivalent) versions. By importing after the Python version, the

[issue19232] Speed up _decimal import

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19232] Speed up _decimal import

STINNER Victor added the comment: I proposed something similar for issue #19229. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue19232] Speed up _decimal import

New submission from Stefan Krah: As discussed on python-dev, importing _decimal at the bottom of decimal.py is about 9x slower than importing _decimal directly. -- assignee: skrah components: Extension Modules messages: 199553 nosy: skrah priority: normal severity: normal stage: needs pa