[issue19201] lzma and 'x' mode open

2013-10-11 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: Also tarfile.open() could support "x" mode. -- ___ Python tracker ___ ___ Pytho

[issue19201] lzma and 'x' mode open

2013-10-11 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: Is there any reason why the order of characters matters here? builtins.open() supports them in any order ("br"=="rb", "bw"=="wb", "ba"=="ab", "bx"=="xb"). -- nosy: +Arfrever ___ Python tracker <

[issue19201] lzma and 'x' mode open

2013-10-10 Thread Tim Heaney
Tim Heaney added the comment: Okay, I just made similar issues for gzip (issue19222) and bz2 (issue19223). It's weird how different these three patches are! We're essentially doing the same thing: "please allow the x option to pass through to builtins.open." Why don't these three modules look mor

[issue19201] lzma and 'x' mode open

2013-10-10 Thread Vajrasky Kok
Changes by Vajrasky Kok : Added file: http://bugs.python.org/file32031/add_x_mode_to_lzma.patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue19201] lzma and 'x' mode open

2013-10-10 Thread Vajrasky Kok
Changes by Vajrasky Kok : Removed file: http://bugs.python.org/file32030/add_x_mode_to_lzma.patch ___ Python tracker ___ ___ Python-bugs-list

[issue19201] lzma and 'x' mode open

2013-10-10 Thread Vajrasky Kok
Vajrasky Kok added the comment: Here is the unit test for Tim Heaney's work. There is a test that explicitly tests that we get error when opening in 'x' mode. Also, this test is only for lzma. I think we should create separate tickets for other compression methods. -- keywords: +patch

[issue19201] lzma and 'x' mode open

2013-10-10 Thread STINNER Victor
STINNER Victor added the comment: > Being strict this would be 3.4 material, Why? The patch is trivial, I don't how it could cause a regression. If you don't want regression, add a unit test to test_lzma.py. -- nosy: +haypo ___ Python tracker

[issue19201] lzma and 'x' mode open

2013-10-09 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Looks good. Being strict this would be 3.4 material, but patch is trivial and looks like a oversight. We should check other compression modules like gzip, bzip2, etc. -- nosy: +jcea ___ Python tracker

[issue19201] lzma and 'x' mode open

2013-10-09 Thread Ethan Furman
Changes by Ethan Furman : -- nosy: +ethan.furman stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue19201] lzma and 'x' mode open

2013-10-08 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue19201] lzma and 'x' mode open

2013-10-08 Thread Tim Heaney
Changes by Tim Heaney : -- versions: +Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue19201] lzma and 'x' mode open

2013-10-08 Thread Tim Heaney
New submission from Tim Heaney: I love the 'x' mode open in recent versions of Python. I just discovered that lzma.open doesn't support it. It seems there's an elif that explicitly checks the modes allowed. I added "x" and "xb" to the choices and now it works as I would like. -- files