[issue18916] Various out-of-date Lock text in 3.2+

Berker Peksag added the comment: Thanks for the path, Christopher. -- assignee: -> docs@python components: +Documentation -Interpreter Core nosy: +berker.peksag, docs@python resolution: -> fixed stage: needs patch -> resolved status: open -> closed versions: +Python 3.5, Python 3.6 -Py

[issue18916] Various out-of-date Lock text in 3.2+

Roundup Robot added the comment: New changeset 203c9c4ccb2a by Berker Peksag in branch '3.5': Issue #18916: Update thread module docstrings https://hg.python.org/cpython/rev/203c9c4ccb2a New changeset 57a475e0e378 by Berker Peksag in branch 'default': Issue #18916: Update thread module docstring

[issue18916] Various out-of-date Lock text in 3.2+

Christopher Welborn added the comment: I meant to say 'attempting to work on the 3.4 arg clinic version', i can't make any promises. I'm using it as a learning experience but probably won't yield any real results any time soon. -- ___ Python tracker

[issue18916] Various out-of-date Lock text in 3.2+

Christopher Welborn added the comment: Here's the 3.3 version, with the PyThread_allocate_lock comment in the lock type. Still working on the 3.4 argument clinic version. -- Added file: http://bugs.python.org/file33838/threading.lock.docs.3.3-with-comment.patch ___

[issue18916] Various out-of-date Lock text in 3.2+

Changes by Christopher Welborn : Removed file: http://bugs.python.org/file33819/threading.lock.docs3.3.patch ___ Python tracker ___ ___ Python

[issue18916] Various out-of-date Lock text in 3.2+

R. David Murray added the comment: Yes, the latter: since someone thought it was important to mention, but only people working with the C code would benefit, it ought to be a comment in the C source. If there's no AC patch for threading yet, then there's no problem with that, and your patch w

[issue18916] Various out-of-date Lock text in 3.2+

Changes by Christopher Welborn : Removed file: http://bugs.python.org/file33818/threading.lock.docs.patch ___ Python tracker ___ ___ Python-bu

[issue18916] Various out-of-date Lock text in 3.2+

Christopher Welborn added the comment: Yep, I missed the PyThread_allocate_lock reference. As far as the Argument Clinic Derby, I've been following the python-dev list and reading about Argument Clinic, but I don't know enough about it to do the conversion. It's a really good tool from what I

[issue18916] Various out-of-date Lock text in 3.2+

R. David Murray added the comment: Thanks for working on this. The patch looks pretty good. I would prefer to flow the two lines in the Lock docstring as a paragraph, rather than have once sentence per line. Also, the OP mentions that the docs for type(Lock) mention PyThread_allocate_lock..

[issue18916] Various out-of-date Lock text in 3.2+

Christopher Welborn added the comment: Hello, my name is Chris Welborn (or Cj). I've been looking for opportunities to work on python. I figured a little Doc fix would be perfect for my first patch, as you originally planned. I ran the python unit-tests and `make test`, plus a 'patchcheck'. Ev

[issue18916] Various out-of-date Lock text in 3.2+

R. David Murray added the comment: Thanks. I suspect someone will indeed latch on to this soon enough. We use the 'versions' to track what version we are going to fix the bug in. So I've removed 3.2, since that only gets security fixes, and 3.5, since that doesn't exist yet. (If we don't fi

[issue18916] Various out-of-date Lock text in 3.2+

New submission from Tim Peters: Here under 3.3.2: """ >>> from threading import Lock >>> help(Lock) Help on built-in function allocate_lock in module _thread: allocate_lock(...) allocate_lock() -> lock object (allocate() is an obsolete synonym) Create a new lock object. See he