[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker ___ __

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

miss-islington added the comment: New changeset 9e1c7ed9aaa4dea413f1b3ed92bb79cccb2f50eb by Miss Islington (bot) in branch '3.7': bpo-18799: Resurrect test_404 in test_xmlrpc. (GH-11196) https://github.com/python/cpython/commit/9e1c7ed9aaa4dea413f1b3ed92bb79cccb2f50eb -- nosy: +miss

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

Change by miss-islington : -- pull_requests: +10467 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

Serhiy Storchaka added the comment: Thank you Vajrasky. The restored test is passed locally and on CI. Let try it on buildbots. -- versions: +Python 3.8 -Python 3.3, Python 3.4 ___ Python tracker __

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

Change by Vajrasky Kok : -- pull_requests: +10435 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

Vajrasky Kok added the comment: Serhiy, okay, I'll create a pull request soon (in 2-3 days). -- ___ Python tracker ___ ___ Python-b

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

Serhiy Storchaka added the comment: Vajrasky, do you mind to create a pull request on GitHub for your patch? -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

Ezio Melotti added the comment: We can always try to apply the patch and see what happens -- if the test starts failing again we can revert it. -- nosy: +ezio.melotti stage: -> patch review type: -> behavior versions: +Python 3.3 ___ Python tracker

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

Vajrasky Kok added the comment: Yes, I agree with you, R. David Murray. But there are some reasons why I try to resurrect this dormant test: 1. This test was disabled on 19 January 2008. http://hg.python.org/cpython/rev/859bf85a556a It has been more than 5 years. Many things happened. 2. In t

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

R. David Murray added the comment: "A lot of false alarms" means usually it works, but then sometimes it doesn't. So just testing it on a couple of platforms isn't sufficient, unfortunately. -- nosy: +r.david.murray ___ Python tracker

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

New submission from Vajrasky Kok: There is a dormant test in Lib/test/test_xmlrpc.py (line 579): # [ch] The test 404 is causing lots of false alarms. def XXXtest_404(self): # send POST with http.client, it should return 404 header and # 'Not Found' message. conn =