[issue18797] Don't needlessly change refcounts of dummy objects for sets

Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue18797] Don't needlessly change refcounts of dummy objects for sets

Roundup Robot added the comment: New changeset ac6dab1819c4 by Raymond Hettinger in branch 'default': Issue 18797: Remove unneeded refcount adjustments for dummy objects. http://hg.python.org/cpython/rev/ac6dab1819c4 -- nosy: +python-dev ___ Python t

[issue18797] Don't needlessly change refcounts of dummy objects for sets

Raymond Hettinger added the comment: > I think we shouldn't distinguish between debug and non-debug mode. That makes good sense. Attaching a new patch without the #ifdefs. -- Added file: http://bugs.python.org/file31402/no_refcnt_dummy2.diff ___ Pyth

[issue18797] Don't needlessly change refcounts of dummy objects for sets

Antoine Pitrou added the comment: I can't think of any counter-indication but I think we shouldn't distinguish between debug and non-debug mode. That way the debug hooks can check that the refcounting optimization is right. -- ___ Python tracker

[issue18797] Don't needlessly change refcounts of dummy objects for sets

Changes by Antoine Pitrou : -- nosy: +Mark.Shannon, tim.peters ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18797] Don't needlessly change refcounts of dummy objects for sets

Changes by Raymond Hettinger : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue18797] Don't needlessly change refcounts of dummy objects for sets

New submission from Raymond Hettinger: AFAICT, there is no reason for sets to incref and decref dummy objects. The dummy object address is used as placeholders in the hash table but it is never accessed by set the logic. As long the one reference is held at the time the dummy object is crea