[issue18794] select.devpoll objects have no close() method

STINNER Victor added the comment: Charles-François Natali and Guido van Rossum: thanks for your reviews ;-) -- ___ Python tracker ___

[issue18794] select.devpoll objects have no close() method

Roundup Robot added the comment: New changeset ccbe2132392b by Victor Stinner in branch 'default': Close #18794: Add a fileno() method and a closed attribute to select.devpoll http://hg.python.org/cpython/rev/ccbe2132392b -- nosy: +python-dev resolution: -> fixed stage: needs patch -> c

[issue18794] select.devpoll objects have no close() method

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue18794] select.devpoll objects have no close() method

STINNER Victor added the comment: Updated patch: move tests to the right test files and test that close() can be called more than once. -- Added file: http://bugs.python.org/file31404/devpoll_close-2.patch ___ Python tracker

[issue18794] select.devpoll objects have no close() method

Serhiy Storchaka added the comment: poll, devpoll, epoll and kqueue are tested in test_poll.py, test_devpoll.py, test_epoll.py and test_kqueue.py test files. -- ___ Python tracker _

[issue18794] select.devpoll objects have no close() method

STINNER Victor added the comment: "This all sounds fine to fix without waiting for anything else -- can you attach a patch here?" I opened the issue as a reminder for me. Here is a patch. * Add close() and fileno() methods and a closed attribute (property) to devpoll object * Document close

[issue18794] select.devpoll objects have no close() method

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue18794] select.devpoll objects have no close() method

STINNER Victor added the comment: "Just to be explicit (there are typos in Victor's original messages): it's about select.devpoll, for Solaris-derivatives with /dev/poll, and not for select.poll, based on poll() syscall." Oops sorry, yes, I'm talking about select.devpoll, its structure has a "

[issue18794] select.devpoll objects have no close() method

Charles-François Natali added the comment: Just to be explicit (there are typos in Victor's original messages): it's about select.devpoll, for Solaris-derivatives with /dev/poll, and not for select.poll, based on poll() syscall. -- ___ Python tracke

[issue18794] select.devpoll objects have no close() method

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18794] select.devpoll objects have no close() method

Guido van Rossum added the comment: This all sounds fine to fix without waiting for anything else -- can you attach a patch here? -- ___ Python tracker ___ _

[issue18794] select.devpoll objects have no close() method

STINNER Victor added the comment: See also issue #16853 "add a Selector to the select module". -- ___ Python tracker ___ ___ Python-bu

[issue18794] select.devpoll objects have no close() method

New submission from STINNER Victor: select.epoll and select.kqueue objects have a close() method, but not select.poll objects, whereas all these objects store internally a file descriptor. select.poll lacks also a fileno() method. I added the fileno() method in my implementation of the PEP 44