[issue18780] SystemError when formatting int subclass

Eli Bendersky added the comment: On Tue, Jun 24, 2014 at 3:18 PM, Ned Deily wrote: > > Ned Deily added the comment: > > It is described in the developer's guide. The current status is > summarized here: > > https://docs.python.org/devguide/devcycle.html#summary > > Excellent. Thanks Ned.

[issue18780] SystemError when formatting int subclass

Ned Deily added the comment: It is described in the developer's guide. The current status is summarized here: https://docs.python.org/devguide/devcycle.html#summary -- ___ Python tracker

[issue18780] SystemError when formatting int subclass

Eli Bendersky added the comment: On Tue, Jun 24, 2014 at 2:29 PM, Ned Deily wrote: > > Ned Deily added the comment: > > The 3.3 branch is now only open for security fixes so this issue doesn't > appear to warrant backporting there. > > -- > These questions keep popping up in various pl

[issue18780] SystemError when formatting int subclass

Ethan Furman added the comment: Cool, leaving it closed. -- versions: -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18780] SystemError when formatting int subclass

Ned Deily added the comment: The 3.3 branch is now only open for security fixes so this issue doesn't appear to warrant backporting there. -- nosy: +ned.deily ___ Python tracker ___

[issue18780] SystemError when formatting int subclass

Ethan Furman added the comment: Should this patch also go into the 3.3 branch? It only went into 3.4. If yes, how should I go about doing that? -- assignee: -> ethan.furman ___ Python tracker ___

[issue18780] SystemError when formatting int subclass

Roundup Robot added the comment: New changeset 833246d42825 by Ethan Furman in branch 'default': Issue #18780: code cleanup. http://hg.python.org/cpython/rev/833246d42825 -- ___ Python tracker _

[issue18780] SystemError when formatting int subclass

Roundup Robot added the comment: New changeset 33727fbb4668 by Ethan Furman in branch 'default': Close #18780: %-formatting now prints value for int subclasses with %d, %i, and %u codes. http://hg.python.org/cpython/rev/33727fbb4668 -- nosy: +python-dev resolution: -> fixed stage: patc

[issue18780] SystemError when formatting int subclass

Eli Bendersky added the comment: lgtm -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue18780] SystemError when formatting int subclass

Ethan Furman added the comment: Okay, simple fix, patch and tests attached. -- keywords: +patch nosy: +ncoghlan stage: -> patch review Added file: http://bugs.python.org/file31492/issue18780.stoneleaf.01.patch ___ Python tracker

[issue18780] SystemError when formatting int subclass

Ethan Furman added the comment: I'll get my patch separated and over here when I get back home (on a business trip at the moment). -- ___ Python tracker ___

[issue18780] SystemError when formatting int subclass

Changes by Serhiy Storchaka : -- nosy: +barry, eli.bendersky, eric.smith, ethan.furman ___ Python tracker ___ ___ Python-bugs-list mai

[issue18780] SystemError when formatting int subclass

Serhiy Storchaka added the comment: I think we should just use PyNumber_ToBase() for any int and int subclass. The calling __str__() for special case looks weird. -- ___ Python tracker

[issue18780] SystemError when formatting int subclass

STINNER Victor added the comment: formatlong() should copy the string if Py_REFCNT(str) != 1. -- ___ Python tracker ___ ___ Python-bug

[issue18780] SystemError when formatting int subclass

New submission from Serhiy Storchaka: >>> class I(int): ... def __str__(self): ... return 'spam' ... >>> '%i' % (I(42),) Traceback (most recent call last): File "", line 1, in SystemError: Objects/unicodeobject.c:13595: bad argument to internal function This issue is related to i