[issue1866] const arg for PyInt_FromString

Nick Coghlan added the comment: I'm rejecting this due to the effect it has on the output parameters. The patch ends up have to stick (char *) casts in several places because a pointer into the string provided via the char * input parameter is returned by each affected API to the calling func

[issue1866] const arg for PyInt_FromString

Mark Lawrence added the comment: Any opinions as to whether the patch should be reworked for 3.2 or not? -- nosy: +BreamoreBoy versions: -Python 2.7 ___ Python tracker ___ _

[issue1866] const arg for PyInt_FromString

Walter Dörwald added the comment: The patch no longer applies cleanly to the trunk. -- nosy: +doerwalter ___ Python tracker ___ ___ Py

[issue1866] const arg for PyInt_FromString

Changes by Daniel Diniz : -- keywords: +patch versions: +Python 2.7, Python 3.2 -Python 2.5 ___ Python tracker ___ ___ Python-bugs-list

[issue1866] const arg for PyInt_FromString

phil added the comment: Ok. Ran 'make test' before and after patch. Output identical. Attaching output after patch. Added file: http://bugs.python.org/file9417/make_test_after __ Tracker <[EMAIL PROTECTED]> __

[issue1866] const arg for PyInt_FromString

Nick Coghlan added the comment: The test suite is run via test/regrtest.py. If you aren't on windows, 'make test' works as well. For myself, I tend to just run "./python -m test.regrtest" in the directory where I built Python. -- nosy: +ncoghlan __ Track

[issue1866] const arg for PyInt_FromString

Changes by phil: Added file: http://bugs.python.org/file9266/autotest.out.after __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Uns

[issue1866] const arg for PyInt_FromString

phil added the comment: Oh, all right. Just don't tell my boss -- he thinks I'm doing "real" work. :-) I haven't thoroughly studied the test harness, but it looked like /bin/python /lib/python2.5/test/autotest.py was what I should do? The output generated before/after the patch was identi

[issue1866] const arg for PyInt_FromString

Guido van Rossum added the comment: So how about submitting a patch *and* building everything from scratch and running all the unit tests to make sure this doesn't break anything? -- nosy: +gvanrossum priority: -> low __ Tracker <[EMAIL PROTECTED]>

[issue1866] const arg for PyInt_FromString

New submission from phil: In PyInt_FromString(), please change the type of the first arg from char * to const char *. That is, of course, if the function indeed does not write to the string. (I took a quick look at the code; it doesn't appear to.) If the function does modify the string, it sho