[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-08-31 Thread Phil Webster
Phil Webster added the comment: Added tests for labels, a mock function for widget creation, a back option for radiobuttontests, and the docstring fixes that Terry mentioned. -- Added file: http://bugs.python.org/file31542/18592_test_searchdialog2.diff _

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-08-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: For next edit -- docstring for class SearchDialogBase: > +a row of standard radiobuttons (create_option_buttons); This is wrong -- these are Checkbuttons > +a row of dialog specific radiobuttons (create_other_buttons). dialog-specific Radiobuttons

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-08-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: A subtle point about coverage. The target module must be imported. from idlelib import SearchDialogBase as sdb # works. import idlelib.SearchDialogBase as sdb # does not at least not as I invoke coveragepy in my batch file. With this change, the four uncovered

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-08-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: I added the docstrings that I wish had already been present. The only 2.7-3.3 difference in SearchDialogBase is Tkinter/tkinter. -- assignee: -> terry.reedy stage: -> patch review ___ Python tracker

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-08-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0d2b87ec9f2b by Terry Jan Reedy in branch '2.7': Issue #18592: Add docstrings to file being tested (idlelib.SearchDialogBase.py). http://hg.python.org/cpython/rev/0d2b87ec9f2b New changeset e09dfdbeb9a2 by Terry Jan Reedy in branch '3.3': Issue #185

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-08-10 Thread Phil Webster
Phil Webster added the comment: As suggested by Ezio, I factored out the button tests to a common method. -- Added file: http://bugs.python.org/file31220/test_searchdialogbase2.patch ___ Python tracker

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-08-08 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-07-29 Thread Phil Webster
Changes by Phil Webster : -- keywords: +patch Added file: http://bugs.python.org/file31082/test_searchdialogbase.patch ___ Python tracker ___

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-07-29 Thread Phil Webster
New submission from Phil Webster: This is a basic set of tests for SearchDialogBase. It mainly consists of gui code, so I was not completely sure of how/what to test. Before venturing any further, I thought I would make sure I'm heading in the right direction. -- components: IDLE messa