[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Roundup Robot added the comment: New changeset c27527dce71e by Victor Stinner in branch 'default': Issue #18571: Merge duplicate test code http://hg.python.org/cpython/rev/c27527dce71e -- ___ Python tracker ___

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

STINNER Victor added the comment: > I guess you could remove util.pipe() altogether: it wasn't part of the public > API. Ah yes, I wanted to create an issue for that but I forgot. Here you have: issue #18865. -- ___ Python tracker

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Charles-François Natali added the comment: 14.1 --- a/Lib/multiprocessing/util.py 14.2 +++ b/Lib/multiprocessing/util.py 14.13 # 14.14 # Return pipe with CLOEXEC set on fds 14.15 # 14.16 +# Deprecated: os.pipe() creates non-inheritable file descriptors 14.17 +# since Python

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Roundup Robot added the comment: New changeset ef889c3d5dc6 by Victor Stinner in branch 'default': Issue #18571: Implementation of the PEP 446: file descriptors and file handles http://hg.python.org/cpython/rev/ef889c3d5dc6 -- nosy: +python-dev ___ Py

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Added file: http://bugs.python.org/file31488/ca6217fbec85.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Removed file: http://bugs.python.org/file31413/775890a666bf.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

STINNER Victor added the comment: I tested 17211acb65b1.diff on my x86_64 VMs: Linux: Linux-3.9.4-200.fc18.x86_64-x86_64-with-fedora-18-Spherical_Cow => 358 tests OK. OpenIndiana: Solaris-2.11-i86pc-i386-32bit-ELF => 3 tests failed: test_locale test_tcl test_uuid -- none of these failures are

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Added file: http://bugs.python.org/file31427/17211acb65b1.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Removed file: http://bugs.python.org/file31412/43697011a273.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Added file: http://bugs.python.org/file31413/775890a666bf.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Removed file: http://bugs.python.org/file31378/00df7fc6d2ef.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Removed file: http://bugs.python.org/file31235/e4e6f45668c7.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Added file: http://bugs.python.org/file31412/43697011a273.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

STINNER Victor added the comment: > make_inheritable() should ignore errpipe_write, instead of changing twice the > inheritable flag of errpipe_write. Done in the last patch (00df7fc6d2ef.diff). -- ___ Python tracker

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Added file: http://bugs.python.org/file31378/00df7fc6d2ef.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

STINNER Victor added the comment: +if (make_inheritable(py_fds_to_keep) < 0) +goto error; +/* errpipe_write is part of py_fds_to_keep. It must be closed at + exec(), but kept open in the child process until exec() is called. */ +if (_Py_set_inheritable((int)errpipe_write

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Removed file: http://bugs.python.org/file31058/c066794c85cd.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Removed file: http://bugs.python.org/file31234/1f8979a8c2c5.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Added file: http://bugs.python.org/file31235/e4e6f45668c7.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : Added file: http://bugs.python.org/file31234/1f8979a8c2c5.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18571] Implementation of the PEP 446: non-inheritable file descriptors

Changes by STINNER Victor : -- title: Implementation of the PEP 446: non-inheriable file descriptors -> Implementation of the PEP 446: non-inheritable file descriptors ___ Python tracker __