[issue18425] IDLE Unit test for IdleHistory.py

2013-08-18 Thread Ezio Melotti
Ezio Melotti added the comment: > If you are generically opposed to name localization, please take your > case to pydev. I'm not strongly opposed to it, I probably even use it sometimes. In that case I wouldn't have bothered, but YMMV. -- ___ Pytho

[issue18425] IDLE Unit test for IdleHistory.py

2013-08-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ezio: grepping test/*.py for (name)'= self.assertEqual' gets 182 hits in 15 different files. If you are generically opposed to name localization, please take your case to pydev. I also found 'unless = self.assertTrue' and am sure I have seen others in the stdl

[issue18425] IDLE Unit test for IdleHistory.py

2013-08-15 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue18425] IDLE Unit test for IdleHistory.py

2013-08-15 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed superseder: -> IdleHistory.History: eliminate unused parameter; other cleanup. ___ Python tracker ___ __

[issue18425] IDLE Unit test for IdleHistory.py

2013-08-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0e9d41edb2e4 by Terry Jan Reedy in branch '2.7': Issue #18425: Unittests for idlelib.IdleHistory. First patch by R. Jayakrishnan. http://hg.python.org/cpython/rev/0e9d41edb2e4 New changeset c4cac5d73e9d by Terry Jan Reedy in branch '3.3': Issue #184

[issue18425] IDLE Unit test for IdleHistory.py

2013-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: Moved most initialization to method setUp to prevent cascading of test failures. Added info about History.fetch and FetchTest.fetch_test methods. Added tests for non-cyclic and special behavior and for fetch event wrappers. Coverage is essentially 100%. -

[issue18425] IDLE Unit test for IdleHistory.py

2013-08-13 Thread Terry J. Reedy
Changes by Terry J. Reedy : Added file: http://bugs.python.org/file31287/test_idlehistory3.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue18425] IDLE Unit test for IdleHistory.py

2013-08-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: IdleHistory.py is identical in 2.7 and 3.3. It is only imported in PyShell.py (within class PyShell, line 852 in 3.3). History is only initialized once, with the default output_sep. See #18732 for deleting the unneeded parameter and associated cruft. The push

[issue18425] IDLE Unit test for IdleHistory.py

2013-08-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0bb9346665e9 by Terry Jan Reedy in branch '3.3': Issue #18425: Add docstrings to IdleHistory.py. Remove redundant 'history_' http://hg.python.org/cpython/rev/0bb9346665e9 New changeset 22d7c755163d by Terry Jan Reedy in branch '2.7': Issue #18425:

[issue18425] IDLE Unit test for IdleHistory.py

2013-08-08 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18425] IDLE Unit test for IdleHistory.py

2013-07-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Resolution is for when the issue is closed, and I expect this to be closed as 'fixed'. -- assignee: -> terry.reedy resolution: works for me -> stage: -> patch review ___ Python tracker

[issue18425] IDLE Unit test for IdleHistory.py

2013-07-21 Thread R. Jayakrishnan
Changes by R. Jayakrishnan : -- resolution: -> works for me ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue18425] IDLE Unit test for IdleHistory.py

2013-07-18 Thread R. Jayakrishnan
R. Jayakrishnan added the comment: Thanks Terry for "we have the option of gui tests when mocking becomes too complicated" I put two separate classes IdleHistoryMockTest and IdleHistoryTKTest for mock and TK text usages and used TK Text to test IdleHistory.history_do function. This worked for

[issue18425] IDLE Unit test for IdleHistory.py

2013-07-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: As I said on one of the other issues, which I hope you read, we have the option of gui tests when mocking becomes too complicated. So at least for now, put the test that requires marks in a separate test case with requires('gui') in setUPClass. The problem wi

[issue18425] IDLE Unit test for IdleHistory.py

2013-07-13 Thread R. Jayakrishnan
R. Jayakrishnan added the comment: Now we have the mockText, So I updated my test for Idlehistory. The submitted patch2 contains tests for two methods in Idlehistory (history_store and History_do). I hope the tests for history_store are done. But the history_do method tests fails. I explored a

[issue18425] IDLE Unit test for IdleHistory.py

2013-07-10 Thread Todd Rovito
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue18425] IDLE Unit test for IdleHistory.py

2013-07-10 Thread Phil Webster
Changes by Phil Webster : -- nosy: +philwebster ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue18425] IDLE Unit test for IdleHistory.py

2013-07-10 Thread R. Jayakrishnan
New submission from R. Jayakrishnan: Continuing the IDLE unittest framework #15392, unit test for IdleHistory.py. This test depends on mockText and uses the patch by Terry at issue #18365. Because the mockText is still about to commit, first patch http://bugs.python.org/file30865/mock_text2.dif