[issue18415] Normalize single/double quote usage in importlib

2013-07-12 Thread Madison May
Madison May added the comment: No problem, Brett. Glad to hear you could get rid of those few last pesky double quotes. I'm partial to the single quotes as well. -- ___ Python tracker ___

[issue18415] Normalize single/double quote usage in importlib

2013-07-12 Thread Brett Cannon
Brett Cannon added the comment: Thanks for the path, Madison! I also cleaned up the instances using double quotes since it was because I was faking the use of a string's repr instead of explicitly using {!r}. -- resolution: -> fixed stage: commit review -> committed/rejected status: o

[issue18415] Normalize single/double quote usage in importlib

2013-07-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 33d379c2bb79 by Brett Cannon in branch 'default': Issue #18415: Normalize what type of quotes are used with string http://hg.python.org/cpython/rev/33d379c2bb79 -- nosy: +python-dev ___ Python tracker

[issue18415] Normalize single/double quote usage in importlib

2013-07-12 Thread Brett Cannon
Brett Cannon added the comment: Why the stage change? I set it to commit review on purpose as I already did a cursory check and it was fine. I have only have one more paranoid check before do the commit myself. I purposely didn't set patch review as I didn't want anyone wasting their time doin

[issue18415] Normalize single/double quote usage in importlib

2013-07-11 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- stage: commit review -> patch review ___ Python tracker ___ ___ Python-bugs-list m

[issue18415] Normalize single/double quote usage in importlib

2013-07-11 Thread Brett Cannon
Brett Cannon added the comment: I prefer single quotes (easier to type =) and yes, using double quotes instead of escaping is preferred. When I have a chance I will take a look at the patch. -- stage: needs patch -> commit review ___ Python tracker

[issue18415] Normalize single/double quote usage in importlib

2013-07-11 Thread Madison May
Madison May added the comment: Patch using all double quotes. Take your pick :) -- Added file: http://bugs.python.org/file30894/all_double_quotes.patch ___ Python tracker ___ ___

[issue18415] Normalize single/double quote usage in importlib

2013-07-11 Thread Madison May
Madison May added the comment: Patch using all single quotes for string literals, except for 3 cases of double quoted strings that contain single quotes (I thought it was probably preferable to escaping the single quotes). -- keywords: +patch nosy: +madison.may Added file: http://bugs.

[issue18415] Normalize single/double quote usage in importlib

2013-07-09 Thread Brett Cannon
Brett Cannon added the comment: String constants in importlib/_bootstrap.py; pylint noticed the discrepancy. -- ___ Python tracker ___ ___

[issue18415] Normalize single/double quote usage in importlib

2013-07-09 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue18415] Normalize single/double quote usage in importlib

2013-07-09 Thread STINNER Victor
STINNER Victor added the comment: Do you mean in .c and .py files, or in error messages? -- nosy: +haypo ___ Python tracker ___ ___ Py

[issue18415] Normalize single/double quote usage in importlib

2013-07-09 Thread Brett Cannon
New submission from Brett Cannon: Importlib has ended up with a mixed use of single and double quotes. Should clean it up to be consistent. -- assignee: brett.cannon components: Library (Lib) keywords: easy messages: 192771 nosy: brett.cannon priority: low severity: normal stage: needs