[issue1836] 'weekly' rotating logging file rotation incorrect

Changes by Vinay Sajip: -- status: pending -> closed __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue1836] 'weekly' rotating logging file rotation incorrect

Vinay Sajip added the comment: Misc/NEWS updated. Thanks for the reminder! __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscri

[issue1836] 'weekly' rotating logging file rotation incorrect

Christian Heimes added the comment: Please update Misc/NEWS for the bug fix. You forgot to update it for this and another logging fix a week ago. -- nosy: +tiran status: closed -> pending __ Tracker <[EMAIL PROTECTED]> _

[issue1836] 'weekly' rotating logging file rotation incorrect

Vinay Sajip added the comment: Fix checked into trunk and release25-maint. Thanks for the patch, Kathryn. -- resolution: -> fixed status: open -> closed __ Tracker <[EMAIL PROTECTED]> __

[issue1836] 'weekly' rotating logging file rotation incorrect

Changes by Christian Heimes: -- keywords: +easy priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubs

[issue1836] 'weekly' rotating logging file rotation incorrect

Kathryn M Kowalski added the comment: I did not put suggested code in - walking through it and counting days on my fingers I don't think it works. If the desired rollover day is Tuesday (self.dayOfWeek = 1) and today is Tuesday (day = 1) then self.rolloverAt is the seconds to midnight as if d

[issue1836] 'weekly' rotating logging file rotation incorrect

Vinay Sajip added the comment: There's already been a change to this code, since 2.5.1.1. Here's the code in trunk: if when.startswith('W'): day = t[6] # 0 is Monday if day != self.dayOfWeek: if day < self.dayOfWeek: daysToWait = self.dayOfWeek - day - 1 else:

[issue1836] 'weekly' rotating logging file rotation incorrect

Kathryn M Kowalski added the comment: downloaded from ActiveState aug 2007 Python 2.5.1.1 # Case 2) The day to rollover is further in the interval (i.e., today is # day 2 (Wednesday) and rollover is on day 6 (Sunday). Days to # next rollover is simply 6 - 2 - 1, or 3. # Case 3)

[issue1836] 'weekly' rotating logging file rotation incorrect

Vinay Sajip added the comment: Please can you post the data which caused the failure? Is 'the original' the current trunk revision, or a Python release version? There was a patch to this code not long ago, so I'd like to know which code you had originally. Thanks. -- assignee: -> vsajip

[issue1836] 'weekly' rotating logging file rotation incorrect

New submission from Kathryn M Kowalski: Log file did not 'rotate' on day requested. Fixed code in Lib/logging/handlers.py class TimedRotatingFileHandler Compare excerpt of my fix below to the original # Case 2) The day to rollover is further in the interval (i.e., today is # day 2 (Wedne