[issue18283] shutil.which() should support bytes

STINNER Victor added the comment: New changeset 5680f6546dcda550ad70eefa0a5ebf1375303307 by Victor Stinner (Cheryl Sabella) in branch 'master': bpo-18283: Add support for bytes to shutil.which (GH-11818) https://github.com/python/cpython/commit/5680f6546dcda550ad70eefa0a5ebf1375303307 -

[issue18283] shutil.which() should support bytes

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue18283] shutil.which() should support bytes

Change by Cheryl Sabella : -- pull_requests: +11840 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18283] shutil.which() should support bytes

STINNER Victor added the comment: > Would it be worthwhile to make a PR of this for 3.8? Yes. Would you be interested to convert my old patch to a fresh PR? I can help you to work on that. -- ___ Python tracker

[issue18283] shutil.which() should support bytes

Cheryl Sabella added the comment: Would it be worthwhile to make a PR of this for 3.8? -- nosy: +cheryl.sabella versions: +Python 3.8 -Python 3.5 ___ Python tracker ___ __

[issue18283] shutil.which() should support bytes

Changes by Arfrever Frehtes Taifersar Arahesis : -- stage: committed/rejected -> ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18283] shutil.which() should support bytes

STINNER Victor added the comment: which_bytes.patch does not work on Windows. According to Serhiy, it's a new feature and so should wait for Python 3.5. -- resolution: fixed -> status: closed -> open versions: +Python 3.5 -Python 3.4 ___ Python trac

[issue18283] shutil.which() should support bytes

Changes by Arfrever Frehtes Taifersar Arahesis : -- stage: -> committed/rejected versions: +Python 3.4 -Python 3.5 ___ Python tracker ___ ___

[issue18283] shutil.which() should support bytes

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue18283] shutil.which() should support bytes

Roundup Robot added the comment: New changeset a1a05e2724dd by Victor Stinner in branch 'default': Issue #18283: shutil.which() now supports bytes argument, not only text argument. http://hg.python.org/cpython/rev/a1a05e2724dd -- nosy: +python-dev __

[issue18283] shutil.which() should support bytes

STINNER Victor added the comment: Almost all functions of the shutil module support bytes filenames. I tested shutil.copyfile(), shutil.ignore_patterns(), shutil.copytree(), shutil.rmtree() and shutil.move(). I only found one function which only support Unicode filenames: shutil.make_archive(

[issue18283] shutil.which() should support bytes

Serhiy Storchaka added the comment: All low-level functions in the os.path module supports string and bytes paths. But not all high-level functions in the shutil module supports bytes paths. Adding support for bytes paths will complicate implementation and tests. -- versions: +Python 3

[issue18283] shutil.which() should support bytes

Changes by STINNER Victor : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue18283] shutil.which() should support bytes

STINNER Victor added the comment: "What about bytearrays and other byte-like objects? However I'm not sure this enhancement is worth to be accepted. Many other high-level functions in os and shutil modules do not support bytes paths. For shutil.which() there is no backward compatibility with P

[issue18283] shutil.which() should support bytes

Serhiy Storchaka added the comment: What about bytearrays and other byte-like objects? However I'm not sure this enhancement is worth to be accepted. Many other high-level functions in os and shutil modules do not support bytes paths. For shutil.which() there is no backward compatibility with

[issue18283] shutil.which() should support bytes

STINNER Victor added the comment: Here is an implementation. -- keywords: +patch Added file: http://bugs.python.org/file30674/which_bytes.patch ___ Python tracker ___ ___

[issue18283] shutil.which() should support bytes

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18283] shutil.which() should support bytes

Changes by Serhiy Storchaka : -- type: -> enhancement versions: -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18283] shutil.which() should support bytes

New submission from Arfrever Frehtes Taifersar Arahesis: shutil.which() should support bytes. Some other functions in shutil module support bytes. >>> shutil.which("echo") '/bin/echo'