[issue18223] Refactor test_tarfile

2013-06-17 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18223] Refactor test_tarfile

2013-06-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Ezio and Zachary for review. I have included Zachary's patch for issue17689. In addition catching the FileNotFoundError exception used now in test_non_existent_targz_file instead of IOError/OSError + checking errno. -- resolution: -> fixed st

[issue18223] Refactor test_tarfile

2013-06-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4b2188b13dd2 by Serhiy Storchaka in branch '3.3': Issue #18223: Refactor test_tarfile. http://hg.python.org/cpython/rev/4b2188b13dd2 New changeset 5c0816e64aac by Serhiy Storchaka in branch 'default': Issue #18223: Refactor test_tarfile. http://hg.p

[issue18223] Refactor test_tarfile

2013-06-16 Thread Michael Foord
Changes by Michael Foord : -- nosy: -michael.foord ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue18223] Refactor test_tarfile

2013-06-16 Thread Zachary Ware
Zachary Ware added the comment: >Serhiy Storchaka added the comment: > >Oh, sorry, I missed issue17689. That's alright, this is a legitimately different issue that just happens to encompass the purpose of the other. As long as your patch hits all the points mine meant to, I'm not bothered :)

[issue18223] Refactor test_tarfile

2013-06-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, sorry, I missed issue17689. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue18223] Refactor test_tarfile

2013-06-15 Thread Zachary Ware
Zachary Ware added the comment: Looks like a winner, barring a few nits picked on Rietveld. This issue supersedes issue17689, would anyone mind marking that for me? -- ___ Python tracker _

[issue18223] Refactor test_tarfile

2013-06-15 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: test_tarfile already use parametric classes approach for constructing different tests. The proposed patch extends this approach to generating tests for different compression types. In additional this patch: * Makes test_tarfile discoverable. * Uses more s