[issue18186] 2.x subprocess contains set notation

Changes by Ned Deily : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18186] 2.x subprocess contains set notation

Roundup Robot added the comment: New changeset 4b2fdd4dd700 by Ned Deily in branch '2.7': Issue #18186: remove obsolete 2.2 compatibility comment. http://hg.python.org/cpython/rev/4b2fdd4dd700 -- nosy: +python-dev ___ Python tracker

[issue18186] 2.x subprocess contains set notation

Daniel Farina added the comment: Okay, fair enough, in that case, here's a patch to fix the documentation as to not make incorrect statements. -- status: closed -> open Added file: http://bugs.python.org/file30549/fix-subprocess-compat-documentation-v1.patch __

[issue18186] 2.x subprocess contains set notation

Ned Deily added the comment: Your proposed change would still not make the source compatible with Python 2.2 (released over a decade ago) as set() was introduced in 2.4. When the subprocess module was introduced back then, it made sense to maintain compatibility with then-recent releases but i

[issue18186] 2.x subprocess contains set notation

Daniel Farina added the comment: Also, this fix would be for 2.7. My mistake, even though the goal was to import on older Pythons. -- status: closed -> open versions: +Python 2.7 -Python 2.6 ___ Python tracker __

[issue18186] 2.x subprocess contains set notation

Daniel Farina added the comment: Then most assuredly the message at the top is out of date. It seems a pity that for this small change that older python versions cannot use the same code verbatim. It reads: # This module should remain compatible with Python 2.2, see PEP 291. -- ___

[issue18186] 2.x subprocess contains set notation

Berker Peksag added the comment: Python 2.6 only receives security fixes. You can also look at the subprocess32 module: https://pypi.python.org/pypi/subprocess32 -- nosy: +berker.peksag resolution: -> invalid stage: -> committed/rejected status: open -> closed ___

[issue18186] 2.x subprocess contains set notation

New submission from Daniel Farina: I was vendoring subprocess to pick up the change for #16327 when I noticed I could not import it on 2.6. The backwards compatibility claim at the top is 2.2. Included is a tiny patch that uses a semantically equivalent form. -- components: Library (