[issue18084] wave.py should use sys.byteorder to determine endianess

Serhiy Storchaka added the comment: Thank you for your patch. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue18084] wave.py should use sys.byteorder to determine endianess

Roundup Robot added the comment: New changeset ccffce2dde49 by Serhiy Storchaka in branch 'default': Issue #18084: Use sys.byteorder in wave.py. http://hg.python.org/cpython/rev/ccffce2dde49 -- nosy: +python-dev ___ Python tracker

[issue18084] wave.py should use sys.byteorder to determine endianess

Hideaki Takahashi added the comment: Patch updated. Thanks. -- Added file: http://bugs.python.org/file30416/18084_2.patch ___ Python tracker ___ _

[issue18084] wave.py should use sys.byteorder to determine endianess

Serhiy Storchaka added the comment: Yes, please. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue18084] wave.py should use sys.byteorder to determine endianess

Hideaki Takahashi added the comment: I signed it and by eSign and got a signed/filed response yesterday. But according to Lifecycle of a patch in developer guide, my name is needed to be added to Misc/ACKS. Can I update patch to do this? -- ___ Pytho

[issue18084] wave.py should use sys.byteorder to determine endianess

Serhiy Storchaka added the comment: Can you please submit a contributor form? http://python.org/psf/contrib/contrib-form/ http://python.org/psf/contrib/ -- ___ Python tracker __

[issue18084] wave.py should use sys.byteorder to determine endianess

Changes by Hideaki Takahashi : -- keywords: +patch Added file: http://bugs.python.org/file30406/18084.patch ___ Python tracker ___ ___

[issue18084] wave.py should use sys.byteorder to determine endianess

Serhiy Storchaka added the comment: I have added some comments on Rietveld. -- assignee: -> serhiy.storchaka stage: -> patch review type: -> enhancement versions: +Python 3.4 ___ Python tracker _

[issue18084] wave.py should use sys.byteorder to determine endianess

Changes by Antoine Pitrou : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue18084] wave.py should use sys.byteorder to determine endianess

Changes by Hideaki Takahashi : Added file: http://bugs.python.org/file30405/diff ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue18084] wave.py should use sys.byteorder to determine endianess

New submission from Hideaki Takahashi: wave.py uses struct based endianness detecting code. However there is sys.byteorder in Python since Python 2.0. I think wave.py should use sys.byteorder to determine endianness. -- components: Library (Lib) messages: 190235 nosy: hideaki_t priority