[issue18070] change importlib.util.module_for_loader to unconditionally set attributes

2013-05-28 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed ___ Python tracker ___

[issue18070] change importlib.util.module_for_loader to unconditionally set attributes

2013-05-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 185a0e649fb8 by Brett Cannon in branch 'default': Issue #18070: importlib.util.module_for_loader() now sets __loader__ http://hg.python.org/cpython/rev/185a0e649fb8 -- nosy: +python-dev ___ Python tracker

[issue18070] change importlib.util.module_for_loader to unconditionally set attributes

2013-05-27 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue18070] change importlib.util.module_for_loader to unconditionally set attributes

2013-05-27 Thread Eric V. Smith
Eric V. Smith added the comment: I don't think anyone would (or should!) write code that cares, so I think your proposed change is a good one. -- ___ Python tracker ___

[issue18070] change importlib.util.module_for_loader to unconditionally set attributes

2013-05-27 Thread Brett Cannon
New submission from Brett Cannon: importlib.util.module_for_loader (as well as set_package and set_loader) only set those attributes either when they are not already set or when the module is new. I realized this is a problem as it means a reload won't work the way one might expect. I want to