[issue18063] m68k struct alignment issue vs. PyException_HEAD

Antoine Pitrou added the comment: 2.7 doesn't have the C struct fields which were mistakingly sized in test_sys. -- ___ Python tracker ___ ___

[issue18063] m68k struct alignment issue vs. PyException_HEAD

Serhiy Storchaka added the comment: 2.7? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue18063] m68k struct alignment issue vs. PyException_HEAD

Antoine Pitrou added the comment: Should be done now :) -- components: -Interpreter Core resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> behavior versions: +Python 3.3 ___ Python tracker

[issue18063] m68k struct alignment issue vs. PyException_HEAD

Roundup Robot added the comment: New changeset c20b701c66fc by Antoine Pitrou in branch '3.3': Issue #18063: fix some struct specifications in the tests for sys.getsizeof(). http://hg.python.org/cpython/rev/c20b701c66fc New changeset 5c4ca109af1c by Antoine Pitrou in branch 'default': Issue #180

[issue18063] m68k struct alignment issue vs. PyException_HEAD

mirabilos added the comment: Okay, then I’ll ignore those for now. Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18063] m68k struct alignment issue vs. PyException_HEAD

Antoine Pitrou added the comment: Thank you. This is just a bug in the test suite, so it's fine to fix it. -- ___ Python tracker ___ _

[issue18063] m68k struct alignment issue vs. PyException_HEAD

mirabilos added the comment: Include/unicodeobject.h has the same problem; its “state” member currently allocates 8 bit, which is only padded up to 16 bit. asciifields = "nnbP" makes that work too; result attached as after-patch-2.txt Will just changing the testsuite to match reality be enough

[issue18063] m68k struct alignment issue vs. PyException_HEAD

mirabilos added the comment: Sure (attached). -- Added file: http://bugs.python.org/file30374/after-patch-1.txt ___ Python tracker ___ ___

[issue18063] m68k struct alignment issue vs. PyException_HEAD

Antoine Pitrou added the comment: Ok, can you try applying the following patch: diff --git a/Lib/test/test_sys.py b/Lib/test/test_sys.py --- a/Lib/test/test_sys.py +++ b/Lib/test/test_sys.py @@ -703,13 +703,13 @@ class SizeofTest(unittest.TestCase): class C(object): pass check(

[issue18063] m68k struct alignment issue vs. PyException_HEAD

mirabilos added the comment: >>> struct.calcsize("PPnP5Pb") 37 >>> struct.calcsize("PPnP5Pi") 40 >>> struct.calcsize("PPnP5Pb0P") 38 >>> struct.calcsize("PPnP5Pi0P") 40 I already offered to re-run tests in verbose mode “on request” if needed, but the results.txt I attached to issue18061 contain

[issue18063] m68k struct alignment issue vs. PyException_HEAD

Antoine Pitrou added the comment: I suppose it's in SizeofTest specifically (in the future, please quote more detailed test information; you can get it by replaying a test in verbose mode, e.g. "./python -m test -v test_sys"). Can you post the output of: >>> struct.calcsize("PPnP5Pb") >>> st

[issue18063] m68k struct alignment issue vs. PyException_HEAD

mirabilos added the comment: Yes, that's in test_sys. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue18063] m68k struct alignment issue vs. PyException_HEAD

Antoine Pitrou added the comment: > ② This one is pretty severe: AssertionError: 42 != 44 : wrong size for > : got 42, expected 44 What is the context? test_sys? -- nosy: +pitrou ___ Python tracker __

[issue18063] m68k struct alignment issue vs. PyException_HEAD

New submission from mirabilos: Hi, splitting off issue18061 by request of pitrou: struct alignment issue: PyException_HEAD misses explicit alignment instruction; uses invalid (non-portable) alignment assumptions. ABI change on m68k. See issue18061 for details. -- components: Interpre