[issue17898] gettext bug while parsing plural-forms metadata

Changes by A.M. Kuchling : -- assignee: -> akuchling resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue17898] gettext bug while parsing plural-forms metadata

Roundup Robot added the comment: New changeset 54df02192bfc by Andrew Kuchling in branch '3.4': #17898: reset k and v so that the loop doesn't use an old value https://hg.python.org/cpython/rev/54df02192bfc -- ___ Python tracker

[issue17898] gettext bug while parsing plural-forms metadata

Roundup Robot added the comment: New changeset c3d269c01671 by Andrew Kuchling in branch '2.7': #17898: reset k and v so that the loop doesn't use an old value https://hg.python.org/cpython/rev/c3d269c01671 -- nosy: +python-dev ___ Python tracker

[issue17898] gettext bug while parsing plural-forms metadata

Ned Deily added the comment: LGTM. I think it should be backported to 2.7. -- nosy: +ned.deily versions: +Python 3.4, Python 3.5 ___ Python tracker ___ __

[issue17898] gettext bug while parsing plural-forms metadata

A.M. Kuchling added the comment: I would apply this change to 3.4 and 3.5. Should I also backport it to 2.7? I think the same bug applies there, though I haven't verified this or tried my patch. -- ___ Python tracker

[issue17898] gettext bug while parsing plural-forms metadata

A.M. Kuchling added the comment: Adding a link to a bitbucket repo. -- hgrepos: +304 ___ Python tracker ___ ___ Python-bugs-list maili

[issue17898] gettext bug while parsing plural-forms metadata

A.M. Kuchling added the comment: Proposed patch against 3.5. -- keywords: +patch nosy: +akuchling stage: test needed -> patch review Added file: http://bugs.python.org/file38915/issue17898.patch ___ Python tracker

[issue17898] gettext bug while parsing plural-forms metadata

Steve Strassmann added the comment: Sorry, I haven't installed python 3.*, I just have default Mac OS python 2.7. Here's a minimal test case. Tar expands to file structure: ./test.py

[issue17898] gettext bug while parsing plural-forms metadata

Terry J. Reedy added the comment: Since the other two listed inner-loop issues apply to 3.x, I would guess that this does also. Steve, can you test with 3.3? And provide a *minimal* test case? -- nosy: +terry.reedy stage: -> test needed ___ Python

[issue17898] gettext bug while parsing plural-forms metadata

Steve Strassmann added the comment: There seem to be several bugs involving this particular inner loop in gettext._parse(), but I don't think they're equivalent. The present bug (issue17898) is that parsing a plural header breaks the following header when it happens to be a comment. issue1475

[issue17898] gettext bug while parsing plural-forms metadata

R. David Murray added the comment: Does this bear any relationship to issue 1475523? (And yes, I know it is...sad...that that issue hasn't been fixed yet.) -- nosy: +r.david.murray ___ Python tracker

[issue17898] gettext bug while parsing plural-forms metadata

Changes by Ned Batchelder : -- nosy: +nedbat ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17898] gettext bug while parsing plural-forms metadata

New submission from Steve Strassmann: The gettext.py parser used by django (lib/python2.7/gettext.py), GNUTranslations._parse(), around line 313 does not use clean values for k,v on each iteration ("for item in tmsg.splitlines():") To reproduce the problem (see traceback, below), try parsing a