[issue17516] Dead code should be removed

STINNER Victor added the comment: Thanks for the different reviews. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue17516] Dead code should be removed

STINNER Victor added the comment: test_create_autospec_unbound_methods() of Lib/unittest/test/testmock/testhelpers.py contains dead code because of a known issue. I created issue #17548 to track this function. -- ___ Python tracker

[issue17516] Dead code should be removed

Roundup Robot added the comment: New changeset 313bcff51900 by Victor Stinner in branch 'default': Issue #17516: use comment syntax for comments, instead of multiline string http://hg.python.org/cpython/rev/313bcff51900 New changeset 33bdd0a985b9 by Victor Stinner in branch 'default': Issue #175

[issue17516] Dead code should be removed

Georg Brandl added the comment: The instance in reindent.py uses the "docstring for attributes" feature that some documentation tools supports, which is a unused string *after* the attribute. When you turn that into a comment, put the comment *before* the attribute. -- nosy: +georg.br

[issue17516] Dead code should be removed

STINNER Victor added the comment: For the dead code in test_posix.py, see issue #9246. -- ___ Python tracker ___ ___ Python-bugs-list

[issue17516] Dead code should be removed

R. David Murray added the comment: > Oh, it looks like you are right: useless strings are already removed > during compilation. But it looks a little bit surprising to me to use a > multiline string for a comment. I prefer classic # comments. I was surprised by this as well. I think the comme

[issue17516] Dead code should be removed

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review type: -> enhancement ___ Python tracker ___ ___ Python-bugs-

[issue17516] Dead code should be removed

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue17516] Dead code should be removed

Raymond Hettinger added the comment: The code in test_peepholer should be removed. That code isn't run directly. Instead, it is tested for a correct disassembly. -- nosy: +rhettinger ___ Python tracker _

[issue17516] Dead code should be removed

STINNER Victor added the comment: Here is a concrete patch. > Your "dead code" looks like multiline comments (at least it is > in the email case). I thought those were optimized away when > the pyc is written. Oh, it looks like you are right: useless strings are already removed during compila

[issue17516] Dead code should be removed

R. David Murray added the comment: Your "dead code" looks like multiline comments (at least it is in the email case). I thought those were optimized away when the pyc is written. What is "almost dead code"? If it is the stuff that is only applicable to a given platform, then presumably it is

[issue17516] Dead code should be removed

STINNER Victor added the comment: "Almost Dead code" is code generally considered as useless, but many Python unit tests use such code. Dummy example: try: obj.attr except AttributeError: pass I don't think that we should touch this code, it's just for information. -- _

[issue17516] Dead code should be removed

New submission from STINNER Victor: Using my astoptimizer project and the hook proposed in the issue #17515, I found the following dead code. https://bitbucket.org/haypo/astoptimizer Some code is not dead or unreachable in the general case, but only on a specific platform. I ran astoptimizer w