[issue1746656] IPv6 Interface naming/indexing functions

Changes by Charles-François Natali : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1746656] IPv6 Interface naming/indexing functions

Antoine Pitrou added the comment: > My first commit :-) > What's the next step? > Can this issue be closed, or should I wait until the tests pass on > some buildbot? You can close the issue nevertheless (as "fixed" / "committed/rejected"). It can be reopened later if there's a buildbot failure.

[issue1746656] IPv6 Interface naming/indexing functions

Charles-François Natali added the comment: > @neologix: You can commit it into Python 3.3. Tell me if you need > help ;-) My first commit :-) What's the next step? Can this issue be closed, or should I wait until the tests pass on some buildbot? --

[issue1746656] IPv6 Interface naming/indexing functions

Roundup Robot added the comment: New changeset cc60d0283fad by Charles-François Natali in branch 'default': Issue #1746656: make if_nameindex(), if_indextoname() and if_nametoindex() http://hg.python.org/cpython/rev/cc60d0283fad -- ___ Python tracker

[issue1746656] IPv6 Interface naming/indexing functions

STINNER Victor added the comment: > that patch looks good I tested it with non-ASCII interface names: it works as expected with ASCII and UTF-8 locales. It's the first time that I see the "O&" format for Py_BuildValue(), I didn't know this one. The patch looks good. @neologix: You can commit i

[issue1746656] IPv6 Interface naming/indexing functions

Gregory P. Smith added the comment: that patch looks good. though I do wish we had a function similar to PyObject_AsStringEncodedFSDefault() so that the ParseTuple call wasn't needed for this relatively common operation when interfacing with system library calls that deal in C strings.

[issue1746656] IPv6 Interface naming/indexing functions

Charles-François Natali added the comment: > You use UTF-8 encoding: Here's an updated patch taking your comments into account (I'm really blissfully ignorant when it comes to encoding issues, so I hope it will be OK this time). -- Added file: http://bugs.python.org/file22039/socket_

[issue1746656] IPv6 Interface naming/indexing functions

Changes by Charles-François Natali : Removed file: http://bugs.python.org/file22025/socket_if.diff ___ Python tracker ___ ___ Python-bugs-li

[issue1746656] IPv6 Interface naming/indexing functions

STINNER Victor added the comment: Example with a non-ASCII interface name: $ sudo tunctl -u haypo -t unicodeé Set 'unicodeé' persistent and owned by uid 1000 $ sudo ifconfig -a|grep unicode|hexdump -C 75 6e 69 63 6f 64 65 c3 a9 20 4c 69 6e 6b 20 65 |unicode.. Link e| 0010 6e 6

[issue1746656] IPv6 Interface naming/indexing functions

STINNER Victor added the comment: > Here's a patch: > - those functions now accept and return str, not bytes arrays You use UTF-8 encoding: +"Is", ni[i].if_index, ni[i].if_name); +if (!PyArg_ParseTuple(args, "s:if_nametoindex", &ifname)) You should also use the FS encoding

[issue1746656] IPv6 Interface naming/indexing functions

Changes by Santoso Wijaya : -- nosy: +santa4nt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue1746656] IPv6 Interface naming/indexing functions

Charles-François Natali added the comment: Here's a patch: - those functions now accept and return str, not bytes arrays - some of them were not declared static, it's now fixed - use PyErr_SetFromErrno when errno is set - add tests (return type, nonexistent interface name/index and invalid argum

[issue1746656] IPv6 Interface naming/indexing functions

Antoine Pitrou added the comment: Sorry to reopen, but do these methods really have to return *byte strings* for interface names? In Python 3, we usually take the position that textually meaningful data should be str, not bytes (even filenames under POSIX). The usual way to do this is to use

[issue1746656] IPv6 Interface naming/indexing functions

Nadeem Vawda added the comment: All the buildbots are back to normal. It looks like FreeBSD was having the same problem as OS X. -- ___ Python tracker ___

[issue1746656] IPv6 Interface naming/indexing functions

Roundup Robot added the comment: New changeset b6aafb20e5f5 by Gregory P. Smith in branch 'default': issue #1746656: Fix for OS X. configure and #include changes so that the socket http://hg.python.org/cpython/rev/b6aafb20e5f5 -- ___ Python tracker

[issue1746656] IPv6 Interface naming/indexing functions

Nadeem Vawda added the comment: OK, that's great. It'll be another couple of hours before I can do anything from the FreeBSD side; I'm still waiting for the ISO to finish downloading :/ -- ___ Python tracker ___

[issue1746656] IPv6 Interface naming/indexing functions

Gregory P. Smith added the comment: thanks i'll take a look at OS X here. obviously i did development and testing on linux. -- ___ Python tracker ___

[issue1746656] IPv6 Interface naming/indexing functions

Nadeem Vawda added the comment: The OpenIndiana bots are now green, but the BSD and OS X bots are still failing. It seems that on those systems, depends on and maybe some other headers, so the current configure script detects it as "present but not usable". I'm currently setting up a FreeBSD

[issue1746656] IPv6 Interface naming/indexing functions

Roundup Robot added the comment: New changeset 434dfe42fde1 by Nadeem Vawda in branch 'default': Fix _socket compilation failures on non-Linux buildbots (cf. issue #1746656). http://hg.python.org/cpython/rev/434dfe42fde1 -- ___ Python tracker

[issue1746656] IPv6 Interface naming/indexing functions

Nadeem Vawda added the comment: Also failing to compile on OS X: http://www.python.org/dev/buildbot/all/builders/AMD64%20Leopard%203.x/builds/1385/steps/test/logs/stdio The problem seems to be that is not being included on these non-Linux systems. Looking at Modules/socketmodule.h reveals tha

[issue1746656] IPv6 Interface naming/indexing functions

STINNER Victor added the comment: > The _socket module doesn't compile on OpenIndiana anymore Same problem of FreeBSD 8.2: http://www.python.org/dev/buildbot/all/builders/AMD64%20FreeBSD%208.2%203.x/builds/291/steps/test/logs/stdio -- ___ Python tra

[issue1746656] IPv6 Interface naming/indexing functions

STINNER Victor added the comment: > New changeset c2515cb23d9b by Gregory P. Smith in branch 'default': > Issue #1746656: Add if_nameindex, if_nametoindex, if_indextoname The _socket module doesn't compile on OpenIndiana anymore: http://www.python.org/dev/buildbot/all/builders/AMD64%20OpenIndia

[issue1746656] IPv6 Interface naming/indexing functions

Gregory P. Smith added the comment: I added these with conditional compilation via autoconf for use on posix systems. These methods are not IPv6 specific. Anyone who wants to see them supported on windows will need to add whatever conditional compilation magic is required to enable that on a

[issue1746656] IPv6 Interface naming/indexing functions

Roundup Robot added the comment: New changeset c2515cb23d9b by Gregory P. Smith in branch 'default': Issue #1746656: Add if_nameindex, if_nametoindex, if_indextoname http://hg.python.org/cpython/rev/c2515cb23d9b -- nosy: +python-dev ___ Python tracke

[issue1746656] IPv6 Interface naming/indexing functions

Changes by Terry J. Reedy : -- versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue1746656] IPv6 Interface naming/indexing functions

Gregory P. Smith added the comment: What is the status of these methods? On the windows side, it appears that these are only available in Vista and later so we'll need some conditional compliation magic there: http://msdn.microsoft.com/en-us/library/bb408409(VS.85).aspx fyi - the imple

[issue1746656] IPv6 Interface naming/indexing functions

Changes by Daniel Diniz : -- stage: -> test needed versions: +Python 2.7, Python 3.1 -Python 2.6 ___ Python tracker ___ ___ Python-

[issue1746656] IPv6 Interface naming/indexing functions

Christian Heimes added the comment: How do you know that the patch is working when you don't know how to test it? Nobody is going to apply new features without unit tests. -- nosy: +tiran _ Tracker <[EMAIL PROTECTED]>

[issue1746656] IPv6 Interface naming/indexing functions

Changes by Gabriel de Perthuis : -- nosy: +onyxg7 type: -> rfe _ Tracker <[EMAIL PROTECTED]> _