[issue17464] Improve Test Coverage Of Pydoc

R. David Murray added the comment: As discussed with Matt, I deleted the allmethods tests, since the current behavior is actually a bug. pydoc itself doesn't use allmethods, but I did find that numpy at least does so. A separate issue will be opened for that bug. -- resolution: -> f

[issue17464] Improve Test Coverage Of Pydoc

Roundup Robot added the comment: New changeset 474f078ec958 by R David Murray in branch 'default': #17464: improve pydoc test coverage. http://hg.python.org/cpython/rev/474f078ec958 -- nosy: +python-dev ___ Python tracker

[issue17464] Improve Test Coverage Of Pydoc

Matt Bachmann added the comment: Eh, sorry... I tried to do a less fragile way of generating the configuration dict. Tried a few things but it very quickly got messy and even worse started to smell like testing the method with... the method being tested. I am open to ideas though. --

[issue17464] Improve Test Coverage Of Pydoc

Matt Bachmann added the comment: Thanks for the feedback :-D Changes: Utilize test.support.temp_cwd() Removed imports that this made unnecessary Awesome trick! Cut line length down. Don't worry about nitpicking. Anything to get this to be as good as possible. I added an explanation to the t

[issue17464] Improve Test Coverage Of Pydoc

R. David Murray added the comment: Thanks for the patch. Rather than create and destroy a directory for every test (setUp/tearDown), it is possible to use the test.support.temp_cwd context manager to create and destroy one inside the single tests that need it. A nit: we prefer to keep the lin

[issue17464] Improve Test Coverage Of Pydoc

Matt Bachmann added the comment: --Changes assertequals to assertequal --Removes maxdiff as it should not really be there in the first place --Creates an explicit testdir, and cleans it up --Last patch did not actually apply cleanly... I reverted and applied this one and this seems to work

[issue17464] Improve Test Coverage Of Pydoc

Matt Bachmann added the comment: Sure thing, ill make the improvements and upload a new patch. Thanks! -- ___ Python tracker ___ ___ P

[issue17464] Improve Test Coverage Of Pydoc

Radu Voicilas added the comment: Hi, Here are some small comments to your otherwise good to have patch: -- assertEquals has been deprecated in favor of assertEqual, and usually it's great to be consistent across the test suite -- likewise maxDiff should be max_diff mainly because of consistenc

[issue17464] Improve Test Coverage Of Pydoc

New submission from Matt Bachmann: Adds some test coverage to pydoc. -- files: pydoctests.patch keywords: patch messages: 184486 nosy: Matt.Bachmann priority: normal severity: normal status: open title: Improve Test Coverage Of Pydoc versions: Python 3.5 Added file: http://bugs.python.or

[issue17464] Improve Test Coverage Of Pydoc

Changes by Matt Bachmann : -- components: +Tests type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs