[issue17330] Stop checking for directory cache invalidation in importlib

Brett Cannon added the comment: And I have decided to not bother removing the stat check. -- ___ Python tracker ___ ___ Python-bugs-li

[issue17330] Stop checking for directory cache invalidation in importlib

Brett Cannon added the comment: http://hg.python.org/cpython/rev/75e32a0bfd74 and http://hg.python.org/cpython/rev/5fac0ac46f54 have more stronger wording for importlib.invalidate_caches(). What's New already says to call the function without being wishy-washy, so I didn't touch it. -

[issue17330] Stop checking for directory cache invalidation in importlib

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue17330] Stop checking for directory cache invalidation in importlib

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17330] Stop checking for directory cache invalidation in importlib

Brett Cannon added the comment: So Nick Coghlan pointed out that this would require a deprecation warning which is doable using ImportWarning. But that also lowers my motivation to bother since there is no performance benefit. I will, though, at least make it clearer in the What's New doc and

[issue17330] Stop checking for directory cache invalidation in importlib

Erik Bray added the comment: Dropping the implicit invalidation altogether works for me. I was hoping to find a better solution because for the majority of use cases I personally care about the existing behavior is preferable. That said I have to support OSX users as possibly the majority of

[issue17330] Stop checking for directory cache invalidation in importlib

Brett Cannon added the comment: Fine, I asked python-dev, but I said it's going to take a lot to convince me not to rip out the cache invalidation code. -- ___ Python tracker __

[issue17330] Stop checking for directory cache invalidation in importlib

Antoine Pitrou added the comment: I would suggest checking on python-dev before removing the cache freshness check. Some people may rely on it. -- ___ Python tracker ___

[issue17330] Stop checking for directory cache invalidation in importlib

Eric Snow added the comment: Yanking the implicit cache validation does seem to be the simplest solution here. Perhaps we could come up with a complex way of making this work, but I don't think it's worth it. What may be worth it is making the admonition of "use invalidate_caches()" easier t

[issue17330] Stop checking for directory cache invalidation in importlib

Brett Cannon added the comment: So let's see what options we have on the table. Status quo: picks up mutated modules as long as the mtime is granular enough. Fails in the face of added fails under the same conditions. Need to call importlib.invalidate_caches() to avoid this problem. Add st_nl