[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Chris Withers added the comment: New changeset 6a12931c9cb5d472fe6370dbcd2bde72f34dddb4 by Chris Withers (Miss Islington (bot)) in branch '3.7': bpo-17185: Add __signature__ to mock that can be used by inspect for signature (GH11125) https://github.com/python/cpython/commit/6a12931c9cb5d472f

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Change by Chris Withers : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Change by miss-islington : -- pull_requests: +10356 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Chris Withers added the comment: New changeset f7fa62ef4422c9deee050a794fd8504640d9f8f4 by Chris Withers (Xtreak) in branch 'master': bpo-17185: Add __signature__ to mock that can be used by inspect for signature (GH11048) https://github.com/python/cpython/commit/f7fa62ef4422c9deee050a794fd8

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +10284 stage: -> patch review ___ Python tracker ___ ___ Py

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Mario Corchero added the comment: Agree that it sounds reasonable to just set `__signature__` to tell `inspect` where to look at (thanks PEP 362 :P). Not an expert here though. For the partials bug, I'll add Pablo as we were speaking today about something similar :) but that might be unrelat

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Karthikeyan Singaravelan added the comment: While working on partials test case failure I found two more cases along the way. 1. When we call create_autospec it calls _get_signature_object that gets the signature for the given parameter. With functools.partial it returns a partial object a

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Chris Withers added the comment: xtreak - great to see action on this! First step would be to add a unit test for the failure case I reported. I like the tests you have too, but would be good to see the specific failure case covered too. Beyond that, if we can get all the the new tests passi

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Karthikeyan Singaravelan added the comment: Is this being worked on or can I try fixing this? My analysis so far is as below : 1. For functions : inspect.signature looks for attribute __signature__ for functions and while creating the mock for a function since we already have the signature

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Michael Foord added the comment: It was a functionality change, not just a name change. -- ___ Python tracker ___ ___ Python-bugs-list

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Mark Lawrence added the comment: Just curiosity why such a name change? -- components: +Tests nosy: +BreamoreBoy title: create_autospec -> unittest mock create_autospec doesn't correctly replace mocksignature type: -> behavior versions: +Python 3.4, Python 3.5