[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

Christian Heimes added the comment: I've applied the patch in r61086. -- status: open -> closed _ Tracker <[EMAIL PROTECTED]> _ ___ P

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

Neal Norwitz added the comment: On Tue, Feb 26, 2008 at 12:51 AM, Christian Heimes <[EMAIL PROTECTED]> wrote: > > > * Verify that it's faster by compiling python in a release build > > It's roughly the same speed. :/ The variation between timeit runs is > quite high on my machine. The new code

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

Christian Heimes added the comment: > * Fix the format nits. There were missing spaces around = and ==. Oh, I missed the macro above the function. :] > * Verify that it's faster by compiling python in a release build It's roughly the same speed. :/ The variation between timeit runs is quite

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

Changes by Neal Norwitz: -- assignee: nnorwitz -> tiran _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing list Unsubscrib

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

Neal Norwitz added the comment: I looked over the new patch Christian uploaded and I think I understand what's going on. I didn't do a through comparison, but if all the tests pass, I think that's good enough. Good work! Here are the issues I would like to see fixed before check in (all small

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

Christian Heimes added the comment: I did some cleanup (style, var names, <80 chars per line) and combined the patch set into a single patch. The regression tests are passing for a pydebug build. I'm too busy to profile and test the patch with a vanilla Python right now. Pybench is showing a sma

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

Neal Norwitz added the comment: Christian, Could you clean this patch up? Specifically: * Put everything into one patch * Eliminate unnecessary changes (changing variable name or whitespace) * Conform to the style in the file * Verify all the tests run with regrtest.py -u all when built -

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

Christian Heimes added the comment: Can you review the patch and commit it for 2.6? A patch which cleans up the code *and* make it faster is always a good idea. :) -- assignee: -> nnorwitz nosy: +tiran versions: +Python 2.6 _ Tracker <[EMAIL PROTECTE