[issue16871] Cleanup a few minor things

2013-01-08 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Ok for asyncore/asynchat in 3.4 branch. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue16871] Cleanup a few minor things

2013-01-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Agreed. Maintainers of asynchat, tkinter.tix, optparse and difflib must pay attention to this. -- nosy: +aronacher, giampaolo.rodola, gpolo, josiahcarlson, stutzbach resolution: -> rejected stage: patch review -> committed/rejected status: pending ->

[issue16871] Cleanup a few minor things

2013-01-07 Thread Ezio Melotti
Ezio Melotti added the comment: I'm -1 on this, however parts of the patches could be extracted and applied on individual modules in the 'default' branch only. This could be done by the modules' maintainers if they think it's OK. Note that while it's generally not OK doing this kind of refact

[issue16871] Cleanup a few minor things

2013-01-05 Thread Chris Jerdonek
Chris Jerdonek added the comment: Here is another recent comment from Georg on this topic: "And please don't commit cosmetic/"cleanup" changes to bugfix branches in the future." (from http://bugs.python.org/issue16793#msg178372 ) -- nosy: +chris.jerdonek _

[issue16871] Cleanup a few minor things

2013-01-05 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: I elaborate: issue15580. An example of many. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue16871] Cleanup a few minor things

2013-01-05 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: How about innecessary code churn? -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailin

[issue16871] Cleanup a few minor things

2013-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: For me none of these parens help while reading the code (but this is quite subjective). I not object if only a part of these changes will be applied. Review the patches and point what changes should be applied and what changes should not. -- __

Re: [issue16871] Cleanup a few minor things

2013-01-05 Thread Senthil Kumaran
Looks good in most of the places, but at some places the parenthesis are of course helpful for cohesiveness, and this can be quite subjective. With these patches, are you in general removing all instances of parenthesis when it is not required or also considering for places where parens may help wh

[issue16871] Cleanup a few minor things

2013-01-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file28576/minor_things_parens-2.7.diff Added file: http://bugs.python.org/file28577/minor_things_parens-3.2.diff Added file: http://bugs.python.org/file28578/minor_things_parens-3.3.diff Added file: http

[issue16871] Cleanup a few minor things

2013-01-05 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Here is a set of patches which clean a few minor things: add spaces after if/while/return/etc, remove spaces after class/function name, remove redundant parens after if/while/return/etc. One set contains only space changes, another set contains parens chan