[issue16799] start using argparse.Namespace in regrtest

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed ___ Python tracker ___

[issue16799] start using argparse.Namespace in regrtest

Roundup Robot added the comment: New changeset 997de0edc5bd by Serhiy Storchaka in branch 'default': Issue #16799: Switched from getopt to argparse style in regrtest's argument http://hg.python.org/cpython/rev/997de0edc5bd -- nosy: +python-dev ___ Pyt

[issue16799] start using argparse.Namespace in regrtest

Serhiy Storchaka added the comment: Here is updated patch with tests. Please open separated issues if you want suggest semantic changes (removing, renaming or changing behavior of some options). -- Added file: http://bugs.python.org/file31495/regrtest_argparse_2.patch

[issue16799] start using argparse.Namespace in regrtest

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16799] start using argparse.Namespace in regrtest

Serhiy Storchaka added the comment: Thank you for the review Eli. Could you please review issue17974 while I will write tests? As for a duplication I think about using vars(): def main(tests=None, testdir=None, verbose=0, quiet=False, ...): return _main(**vars()) def _main(tests, testdir

[issue16799] start using argparse.Namespace in regrtest

Changes by Serhiy Storchaka : -- stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue16799] start using argparse.Namespace in regrtest

Eli Bendersky added the comment: Looks pretty good, Serhiy. I left some comments in Rietveld. -- ___ Python tracker ___ ___ Python-bug

[issue16799] start using argparse.Namespace in regrtest

Eli Bendersky added the comment: On Mon, Aug 12, 2013 at 1:33 PM, Eli Bendersky wrote: > > Eli Bendersky added the comment: > > On Mon, Aug 12, 2013 at 12:41 PM, Serhiy Storchaka > wrote: > > > > > Serhiy Storchaka added the comment: > > > > Here is a preliminary patch which get rids of > > _con

[issue16799] start using argparse.Namespace in regrtest

Eli Bendersky added the comment: On Mon, Aug 12, 2013 at 12:41 PM, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > Here is a preliminary patch which get rids of > _convert_namespace_to_getopt() and directly uses a Namespace object. > Unfortunately it breaks tests because test

[issue16799] start using argparse.Namespace in regrtest

Serhiy Storchaka added the comment: Here is a preliminary patch which get rids of _convert_namespace_to_getopt() and directly uses a Namespace object. Unfortunately it breaks tests because test_regrtest depends on implementation details of the regrtest module and uses _convert_namespace_to_get

[issue16799] start using argparse.Namespace in regrtest

Serhiy Storchaka added the comment: See also issue17974. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue16799] start using argparse.Namespace in regrtest

Eli Bendersky added the comment: Chris, I was reading through regrtest.py for other reasons and stumbled upon the pointer to this issue. Would you like to update your patch? I will review it. -- nosy: +eli.bendersky ___ Python tracker

[issue16799] start using argparse.Namespace in regrtest

Chris Jerdonek added the comment: FYI, the fix for issue 16854 committed most of this patch, so the patch should be updated before reviewing. -- ___ Python tracker ___ _

[issue16799] start using argparse.Namespace in regrtest

Chris Jerdonek added the comment: Sure, I'd be happy to do that. I'll prepare the patch for the other issue. -- ___ Python tracker ___ __

[issue16799] start using argparse.Namespace in regrtest

Serhiy Storchaka added the comment: May be it would be better to split the patch to two parts -- the fix of usage() bug and the enhancement. -- nosy: +serhiy.storchaka ___ Python tracker __

[issue16799] start using argparse.Namespace in regrtest

Chris Jerdonek added the comment: Thanks. Andrew, could you also take a quick look at this? -- title: switch regrtest from getopt options to argparse Namespace -> start using argparse.Namespace in regrtest ___ Python tracker