[issue1677872] Efficient reverse line iterator

James Emerton added the comment: Attached is an implementation of BufferedReader.readprevline(), as suggested by Antoine. At this point, it seems to be working but I would like to improve the tests when a single result spans multiple chunks. I would particularly like to ensure correct behavio

[issue1677872] Efficient reverse line iterator

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue1677872] Efficient reverse line iterator

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue1677872] Efficient reverse line iterator

Changes by Florent Xicluna : -- nosy: +flox versions: +Python 3.3 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue1677872] Efficient reverse line iterator

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue1677872] Efficient reverse line iterator

Changes by John O'Connor : -- nosy: +jcon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue1677872] Efficient reverse line iterator

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue1677872] Efficient reverse line iterator

Antoine Pitrou added the comment: Suggestions: - do it on BufferedReader, rather than TextIOWrapper: if you want full-speed scanning of log files, you probably want to open them in binary mode - rather than implementing a full-blown iterator, you can start with simple primitives: e.g. a meth

[issue1677872] Efficient reverse line iterator

Mark Russell added the comment: I'll do a C version of the patch (hopefully in the next week or so). -- ___ Python tracker ___ ___

[issue1677872] Efficient reverse line iterator

Alexander Belopolsky added the comment: > The OP has done everything asked of him. Not quite. He split out the documentation part of his patch and it was accepted and committed. Guido raised an issue with the code. OP raised more questions. The code was never updated. Now the patch is ou

[issue1677872] Efficient reverse line iterator

Mark Lawrence added the comment: The OP has done everything asked of him. There are a lot of positive comments about this request. Snag is the patch is in python, I understand that io is now written in C. Could we at this late stage get this into 3.2, or even a minor release of 3.2, or wil

[issue1677872] Efficient reverse line iterator

Changes by Daniel Diniz : -- nosy: +benjamin.peterson, pitrou stage: -> patch review type: -> performance versions: +Python 3.1 -Python 3.0 ___ Python tracker ___ ___

[issue1677872] Efficient reverse line iterator

Mark Russell added the comment: As Guido requested I've split off the generic reversed() and __reversed__() doc additions to this patch against 2.6: http://bugs.python.org/issue1582 The I/O error from reversed(open("/etc/passwd")) was caused by the inner TextIOWrapper calling close() (via the in

[issue1677872] Efficient reverse line iterator

Guido van Rossum added the comment: I'd like to see the doc patches separated out and applied to 2.6 -- they'll automatically merge into 3.0 then. Make that a separate bug please. I like the idea, haven't had time to carefully review the code, but noticed one oddity: >>> for line in reversed(op

[issue1677872] Efficient reverse line iterator

Mark Russell added the comment: Here's an updated version of the patch. Changes: - Updated to work against current py3k branch (r59441) - Added support for universal newlines - Added unit tests - Added docs The patch includes documentation for reversed() and __reversed__() (in

[issue1677872] Efficient reverse line iterator

Mark Russell added the comment: Sure - I'll do an updated patch at the weekend. _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing l

[issue1677872] Efficient reverse line iterator

Christian Heimes added the comment: Some people like the feature, Guido isn't against the feature ... It looks as you have a good chance to get it into Python 3.0. :) Can you come up with a new patch and unit tests? The io module has changed a lot since your initial patch. -- nosy: +tir

[issue1677872] Efficient reverse line iterator

Changes by Guido van Rossum: -- title: Efficient reverse line iterator -> Efficient reverse line iterator versions: +Python 3.0 _ Tracker <[EMAIL PROTECTED]> _