[issue16745] Hide symbols in _decimal.so

Changes by Stefan Krah : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Pyth

[issue16745] Hide symbols in _decimal.so

Roundup Robot added the comment: New changeset ccc372b37fbb by Stefan Krah in branch '3.3': Issue #16745: The gcc visibility pragma is buggy on OpenIndiana and NetBSD. http://hg.python.org/cpython/rev/ccc372b37fbb -- ___ Python tracker

[issue16745] Hide symbols in _decimal.so

Roundup Robot added the comment: New changeset 51b0a150f8aa by Stefan Krah in branch '3.3': Issue #16745: Hide symbols in _decimal.so. http://hg.python.org/cpython/rev/51b0a150f8aa -- ___ Python tracker ___

[issue16745] Hide symbols in _decimal.so

Roundup Robot added the comment: New changeset 24f6c6f3b7bf by Stefan Krah in branch '3.3': Issue #16745: Hide a couple of symbols by making them local. http://hg.python.org/cpython/rev/24f6c6f3b7bf -- nosy: +python-dev ___ Python tracker

[issue16745] Hide symbols in _decimal.so

Meador Inge added the comment: Ah, I missed how big of a line range these pragmas are covering when I scanned the patch before. In that case, I agree with the current patch. -- ___ Python tracker

[issue16745] Hide symbols in _decimal.so

Stefan Krah added the comment: Meador Inge wrote: > Personally I prefer using attributes instead of pragmas. The GCC manual > recommends such as well. I followed www.akkadia.org/drepper/dsohowto.pdf . Drepper seems to be fine with the use of pragmas in internal headers. > There are also othe

[issue16745] Hide symbols in _decimal.so

Meador Inge added the comment: Personally I prefer using attributes instead of pragmas. The GCC manual recommends such as well. There are also other sources in Modules/* that use '__attribute__ ((visibility ("hidden")))'. Namely ctypes and zlib. I can understand that it is more work, but I

[issue16745] Hide symbols in _decimal.so

Changes by Meador Inge : -- nosy: +meador.inge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16745] Hide symbols in _decimal.so

Stefan Krah added the comment: Adding everyone from issue #4555, in case you can think of a different (portable) solution for hiding symbols (with minimal effort). -- nosy: +christian.heimes, dmalcolm, doko, lemburg, loewis, pitrou ___ Python tracker

[issue16745] Hide symbols in _decimal.so

New submission from Stefan Krah: This issue is for the _decimal specific parts from #4555. The patch depends on _Pragma (C99) and gcc >= 4.0 for the contents of the pragma. I think it will work for clang, too. Should the libmpdec API symbols (i.e. the ones starting with mpd_*) be hidden for _dec