[issue16714] Raise exceptions, don't throw

2012-12-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset b227f8f7242d by Andrew Svetlov in branch '2.7': replace threw with raised (#16714) http://hg.python.org/cpython/rev/b227f8f7242d New changeset 74da2dbb5e50 by Andrew Svetlov in branch '3.2': replace threw with raised (#16714) http://hg.python.org/cp

[issue16714] Raise exceptions, don't throw

2012-12-19 Thread Andrew Svetlov
Andrew Svetlov added the comment: Committed. Thanks again, Serhiy! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue16714] Raise exceptions, don't throw

2012-12-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0a5c5399f638 by Andrew Svetlov in branch '2.7': revert comment wording (#16714) http://hg.python.org/cpython/rev/0a5c5399f638 -- ___ Python tracker ___

[issue16714] Raise exceptions, don't throw

2012-12-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I found one error. In Lib/email/header.py for 2.7 'raise' should be reverted to 'throw'. Also I miss a past form. Second patch replaces 'threw' with 'raised'. -- Added file: http://bugs.python.org/file28360/throw_away.patch Added file: http://bugs.pyt

[issue16714] Raise exceptions, don't throw

2012-12-18 Thread Andrew Svetlov
Andrew Svetlov added the comment: Fixed. Thanks, Serhiy. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue16714] Raise exceptions, don't throw

2012-12-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset fdf907708f49 by Andrew Svetlov in branch '3.2': Issue #16714: use 'raise' exceptions, don't 'throw'. http://hg.python.org/cpython/rev/fdf907708f49 New changeset 15a391919deb by Andrew Svetlov in branch '3.3': Issue #16714: use 'raise' exceptions, do

[issue16714] Raise exceptions, don't throw

2012-12-18 Thread Georg Brandl
Georg Brandl added the comment: LGTM, except for: diff -r 907d71668d3c Python/pythonrun.c --- a/Python/pythonrun.cSun Dec 16 21:10:35 2012 +0100 +++ b/Python/pythonrun.cTue Dec 18 19:35:27 2012 +0200 @@ -2518,7 +2518,7 @@ PyOS_CheckStack(void) { __try { -/* alloca

[issue16714] Raise exceptions, don't throw

2012-12-18 Thread Chris Jerdonek
Changes by Chris Jerdonek : -- nosy: +chris.jerdonek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue16714] Raise exceptions, don't throw

2012-12-18 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file28349/raise-2.7.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue16714] Raise exceptions, don't throw

2012-12-18 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file28348/raise-3.2.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue16714] Raise exceptions, don't throw

2012-12-18 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: The proposed patch fixes wording of documentation, comments, etc which use the term 'throw' instead of 'raise' in context of exception raising. -- assignee: docs@python components: Documentation files: raise-3.3.patch keywords: patch messages: 17769