[issue1670765] email.Generator: no header wrapping for multipart/signed

Changes by Srikanth S : -- nosy: +srikanths ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue1670765] email.Generator: no header wrapping for multipart/signed

R. David Murray added the comment: Heh. Copy and paste error. I copied the issue number I wanted to reference, then copied the issue number I needed to open in order to paste the reference, and then promptly forgot that I had to recopy the issue number to paste it... Anyway, the correct cro

[issue1670765] email.Generator: no header wrapping for multipart/signed

Martin von Gagern added the comment: Wrong issue number again, or did you deliberately try to catch me in an infinite see-also loop? ;-) I've tried to work out what issue you meant, but failed so far. -- ___ Python tracker

[issue1670765] email.Generator: no header wrapping for multipart/signed

R. David Murray added the comment: See issue 1670765 for more discussion of the whitespace issues. -- ___ Python tracker ___ ___ Py

[issue1670765] email.Generator: no header wrapping for multipart/signed

R. David Murray added the comment: I actually had the wrong message number entirely. I was trying to reference this one, since it has the additional tests. Fixed in r77525. I backported the fix to 2.6 in r77526 and r77527, forwarded ported to py3k in r77542 (with the addition of the new tes

[issue1670765] email.Generator: no header wrapping for multipart/signed

Martin von Gagern added the comment: You missed a digit in the test comment: s/See issue 96843/See issue 968430/ -- ___ Python tracker ___

[issue1670765] email.Generator: no header wrapping for multipart/signed

R. David Murray added the comment: I've committed fix and the non-disabled tests to trunk in r77517. I updated the comments to point to the relevant RFC and note that the problem is not fixed, just mitigated. I've made a note of the additional tests in my issues list for the email package.

[issue1670765] email.Generator: no header wrapping for multipart/signed

Martin von Gagern added the comment: Here is the corresponding path for python3 (py3k branch). It's mostly the same, except for one additional test which ensures header preservation even if the maxheaderlen argument to Message.as_string is greater than 0. It's called test_long_headers_as_stri

[issue1670765] email.Generator: no header wrapping for multipart/signed

Changes by R. David Murray : -- assignee: barry -> r.david.murray nosy: +r.david.murray stage: test needed -> patch review versions: +Python 2.7, Python 3.2 ___ Python tracker

[issue1670765] email.Generator: no header wrapping for multipart/signed

Martin von Gagern added the comment: OK, here is a patch providing both two test cases and the fix for current trunk. Will probably hack something for python 3 as well, although there the Message.as_string approach works due to the new headerlength argument defaulting to 0. So there I'd adjus

[issue1670765] email.Generator: no header wrapping for multipart/signed

Brian Curtin added the comment: Martin, can you provide a true unit test? Lib\email\test\test_email.py has many examples, and something like this would fit in there. -- nosy: +brian.curtin stage: patch review -> test needed ___ Python tracker

[issue1670765] email.Generator: no header wrapping for multipart/signed

Changes by Brian Curtin : -- keywords: +needs review stage: test needed -> patch review versions: +Python 3.1 -Python 3.0 ___ Python tracker ___ ___

[issue1670765] email.Generator: no header wrapping for multipart/signed

Martin von Gagern added the comment: Let's get some traction here, please! Attached is a test case which will demonstrate the issue. It includes the content of test5.eml as a string so that it won't require additional files. It produces both human-readable output and a suitable exit status. T

[issue1670765] email.Generator: no header wrapping for multipart/signed

Changes by Daniel Diniz : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue1670765] email.Generator: no header wrapping for multipart/signed

Changes by Daniel Diniz : -- stage: -> test needed type: -> behavior versions: +Python 2.6, Python 3.0 ___ Python tracker ___ ___

[issue1670765] email.Generator: no header wrapping for multipart/signed

Martin von Gagern added the comment: Take the attached test5.eml. Run it through the following python script: import email print (email.message_from_file(open("test5.eml")).as_string(False)) The result will have both instances of the X-Long-Line header rewrapped. As the second instance is inclu

[issue1670765] email.Generator: no header wrapping for multipart/signed

Collin Winter added the comment: I'd like some tests demonstrating where the current implementation fails and your patch helps, yes. _ Tracker <[EMAIL PROTECTED]> _ _

[issue1670765] email.Generator: no header wrapping for multipart/signed

Martin von Gagern added the comment: Looks like I missed your comments on this patch. What kind of tests do you have in mind? Tests demonstrating where current implementation fails and my patch will help? Or rather tests checking that this patch won't break anything else? The former would be easy