[issue16611] Cookie.py does not parse httponly or secure cookie flags

Roundup Robot added the comment: New changeset d22fadc18d01 by R David Murray in branch '3.2': #22758: fix regression in handling of secure cookies. https://hg.python.org/cpython/rev/d22fadc18d01 -- ___ Python tracker

[issue16611] Cookie.py does not parse httponly or secure cookie flags

Roundup Robot added the comment: New changeset 0ba6ebd90b9d by Berker Peksag in branch '2.7': Issue #19870: BaseCookie now parses 'secure' and 'httponly' flags. http://hg.python.org/cpython/rev/0ba6ebd90b9d -- ___ Python tracker

[issue16611] Cookie.py does not parse httponly or secure cookie flags

R. David Murray added the comment: Fix committed. Thanks, Julien. If you want to propose a new patch the makes the behavior more consistent/useful with respect to what browsers and servers actually do, feel free to propose one. I'm going to close this issue, though. -- resolution:

[issue16611] Cookie.py does not parse httponly or secure cookie flags

Roundup Robot added the comment: New changeset 0dbe45697efc by R David Murray in branch '3.3': #16611: BaseCookie now parses 'secure' and 'httponly' flags. http://hg.python.org/cpython/rev/0dbe45697efc New changeset f81846c2b746 by R David Murray in branch 'default': Merge #16611: BaseCookie now

[issue16611] Cookie.py does not parse httponly or secure cookie flags

Julien Phalip added the comment: Thanks for the clarification, that makes perfect sense! -- ___ Python tracker ___ ___ Python-bugs-lis

[issue16611] Cookie.py does not parse httponly or secure cookie flags

R. David Murray added the comment: I think a fully logical fix could be implemented for 3.4 (after I commit this), because as you say it is *unlikely* that anyone is relying on the behaviors mentioned as "backward compatibility issues" in the added tests. However, it is *possible* someone is

[issue16611] Cookie.py does not parse httponly or secure cookie flags

Julien Phalip added the comment: Thanks for the review and new patch, David! Your approach makes sense and the patch looks good to me. However, regarding backwards-compatibility, is that really a concern? Currently the deserialization process systematically 1) Adds the 'httponly' and 'secure'

[issue16611] Cookie.py does not parse httponly or secure cookie flags

R. David Murray added the comment: Corrected patch. -- Added file: http://bugs.python.org/file31405/cookie_flags.patch ___ Python tracker ___

[issue16611] Cookie.py does not parse httponly or secure cookie flags

Changes by R. David Murray : Removed file: http://bugs.python.org/file31403/cookie_flags.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue16611] Cookie.py does not parse httponly or secure cookie flags

R. David Murray added the comment: Woops, corrupted patch, and I see a bug... -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue16611] Cookie.py does not parse httponly or secure cookie flags

R. David Murray added the comment: Backward compatibility is a concern. However, having the flags test true when present, which they don't currently, should be considered a bug fix, I think. So, I added a some tests to confirm the current behavior, and wrote a new patch that *just* fixes the