[issue16405] Explain how to set up the whitespace commit hook locally

Nick Coghlan added the comment: Oh, so *that's* why my local hook isn't aborting commits when the whitespace check fails :) -- ___ Python tracker ___ ___

[issue16405] Explain how to set up the whitespace commit hook locally

Ned Deily added the comment: Thanks for the patch, Carol. (I made a few minor changes before committing: to the file paths and to make it clearer that one should choose one of the hooks.) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue16405] Explain how to set up the whitespace commit hook locally

Roundup Robot added the comment: New changeset b494a25915a9 by Ned Deily in branch 'default': Issue #16405: Explain how to set up the whitespace commit hook locally. https://hg.python.org/devguide/rev/b494a25915a9 -- nosy: +python-dev ___ Python track

[issue16405] Explain how to set up the whitespace commit hook locally

Carol Willing added the comment: Patch is ready for review. Ned's feedback on "pretxncommit" hook is added. -- Added file: http://bugs.python.org/file39031/iss-hooks-1.patch ___ Python tracker _

[issue16405] Explain how to set up the whitespace commit hook locally

Carol Willing added the comment: Ned, Thanks for the review and feedback. It seems reasonable to me to mention both the "pretxncommit" hook as well as the "commit" hook as well as your brief comments on the difference between the two. I'll make that change to the patch and resubmit. ---

[issue16405] Explain how to set up the whitespace commit hook locally

Ned Deily added the comment: The wording of the patch looks good to me other than one issue: which hook to use. I notice Nick's suggestion is to use the hg "commit" hook. But in the comments for the checkwhitespace hook itself, "pretxncommit" is the suggested hook. The difference between th

[issue16405] Explain how to set up the whitespace commit hook locally

Carol Willing added the comment: Adds whitespace checking hook setup information to Minimal Configuration section of devguide [1]. Patch is ready for review. [1] https://docs.python.org/devguide/committing.html#minimal-configuration -- keywords: +patch stage: needs patch -> patch revi

[issue16405] Explain how to set up the whitespace commit hook locally

Changes by Carol Willing : -- assignee: -> willingc nosy: +willingc ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue16405] Explain how to set up the whitespace commit hook locally

Changes by Ronald Oussoren : -- nosy: +ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue16405] Explain how to set up the whitespace commit hook locally

Terry J. Reedy added the comment: I would be helped by such an explanation in the devguide. -- nosy: +terry.reedy ___ Python tracker ___ _

[issue16405] Explain how to set up the whitespace commit hook locally

Ezio Melotti added the comment: I'm not against your proposal. If the goal is to explain how to get rid of trailing whitespace then the other solutions should be mentioned too (I think made patchcheck already is). If the goal is to show how to set up local hooks and where to get them, then t

[issue16405] Explain how to set up the whitespace commit hook locally

Nick Coghlan added the comment: Sure, but both of those can fail (forgetting to run make patchcheck, using a different editor from your normal one for some reason) Once the commit hook is set up properly, you get alerted to the problem as soon as you try to commit, rather than having to untang

[issue16405] Explain how to set up the whitespace commit hook locally

Ezio Melotti added the comment: Configuring the editor to remove trailing whitespace, and using make patchcheck are other valid solutions to this problem. -- ___ Python tracker

[issue16405] Explain how to set up the whitespace commit hook locally

New submission from Nick Coghlan: Setting up the same commit checks locally that the main repo enforces for incoming patch sets can save a great deal of frustration with the server rejecting "hg push" for changes (this can be especially frustrating if you have already merged changes across bra