[issue16342] setup.py not compiling with NDEBUG in non-debug builds

2012-10-28 Thread Brett Cannon
Brett Cannon added the comment: Well that was extremely frustrating to find out. Turns out a copy of Lib/_sysconfigdata.py was lingering in my checkout and .hgignore was hiding that fact from me. Fixed .hgignore, deleted the wayward file, and everything is now fine. -- resolution: ->

[issue16342] setup.py not compiling with NDEBUG in non-debug builds

2012-10-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset a2b7a3e1ce66 by Brett Cannon in branch '3.3': Issue #16342: Lib/_sysconfigdata.py is no longer put into Lib, so http://hg.python.org/cpython/rev/a2b7a3e1ce66 -- nosy: +python-dev ___ Python tracker

[issue16342] setup.py not compiling with NDEBUG in non-debug builds

2012-10-28 Thread Brett Cannon
Brett Cannon added the comment: I managed to fix it, but I did such a large swath of fixes that I need a little time to narrow down what did it. Report back later. -- ___ Python tracker ___

[issue16342] setup.py not compiling with NDEBUG in non-debug builds

2012-10-28 Thread Brett Cannon
Brett Cannon added the comment: Just to double-check I didn't screw up, I ran ``make distclean; ./configure; make -j8`` and the problem persists. It is *only* files compiled through setup.py and not by the Makefile. I do not have OPT set, but I do have CFLAGS defined. But even if I explicitly

[issue16342] setup.py not compiling with NDEBUG in non-debug builds

2012-10-27 Thread Ned Deily
Ned Deily added the comment: I can't reproduce this on 10.8 with Apple clang 4.1. Your compile options look a little funky, including a missing -fwrapv. It looks like that option and -DNDEBUG are normally passed from ./configure into the Makefile through the OPT variable. Are you by any cha

[issue16342] setup.py not compiling with NDEBUG in non-debug builds

2012-10-27 Thread Brett Cannon
New submission from Brett Cannon: Discovered on OS X 10.8 with clang 3.1, I'm having build failures for _json, _md5, _sha1, _sha256, _sha3, and _sha512 because _PyUnicode_CheckConsistency() is only defined when defined(Py_DEBUG) && !defined(Py_LIMITED_API) even though it is only used in assert