[issue16330] Use surrogate-related macros

Serhiy Storchaka added the comment: It was a rhetorical question. This code compiled only if Py_UNICODE_SIZE == 2. But I should be more careful. -- ___ Python tracker ___

[issue16330] Use surrogate-related macros

STINNER Victor added the comment: > Oh, how could I miss this? The code does compile with error on Linux with GCC. I don't understand how. -- ___ Python tracker ___

[issue16330] Use surrogate-related macros

Serhiy Storchaka added the comment: Thanks. > Issue #16330: Fix compilation on Windows Oh, how could I miss this? -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue16330] Use surrogate-related macros

Roundup Robot added the comment: New changeset 812f5c379188 by Victor Stinner in branch 'default': Issue #16330: Fix compilation on Windows http://hg.python.org/cpython/rev/812f5c379188 -- ___ Python tracker __

[issue16330] Use surrogate-related macros

STINNER Victor added the comment: "But not all surrogate-related code uses this macros. I suppose this is done inadvertently, somewhere the macro and naked code used in neighboring lines." Yeah, I forgot to use the new macros in these files. Thanks for your patch, I applied it. I also fixed *

[issue16330] Use surrogate-related macros

Roundup Robot added the comment: New changeset 13dd8199c112 by Victor Stinner in branch 'default': Issue #16330: Use surrogate-related macros http://hg.python.org/cpython/rev/13dd8199c112 -- nosy: +python-dev ___ Python tracker

[issue16330] Use surrogate-related macros

New submission from Serhiy Storchaka: A set of macros to work with surrogates was introduced in 3.3: Py_UNICODE_IS_SURROGATE, Py_UNICODE_IS_HIGH_SURROGATE, Py_UNICODE_IS_LOW_SURROGATE, Py_UNICODE_JOIN_SURROGATES, Py_UNICODE_HIGH_SURROGATE, and Py_UNICODE_LOW_SURROGATE. Using this macros make