[issue16197] Several small errors in winreg documentation

Andrew Svetlov added the comment: Committed. Thanks, Zachary! -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue16197] Several small errors in winreg documentation

Roundup Robot added the comment: New changeset 2e7da832219d by Andrew Svetlov in branch '3.3': Issue #16197: Fix several small errors in winreg documentation. http://hg.python.org/cpython/rev/2e7da832219d New changeset f1310219c702 by Andrew Svetlov in branch 'default': Merge issue #16197: Fix s

[issue16197] Several small errors in winreg documentation

Zachary Ware added the comment: v3 looks fine to me! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue16197] Several small errors in winreg documentation

Andrew Svetlov added the comment: I have updated patch. -- Added file: http://bugs.python.org/file27812/winreg_3.3+v3.patch ___ Python tracker ___ ___

[issue16197] Several small errors in winreg documentation

Zachary Ware added the comment: Not bad, but with that scheme we could even go as far as cutting out the 'WindowsError is OSError' bit and make it just """ ..versionchanged:: 3.3 See :ref:`above `. """ -- ___ Python tracker

[issue16197] Several small errors in winreg documentation

Andrew Svetlov added the comment: What's about compromise from attached file? -- Added file: http://bugs.python.org/file27811/winreg_3.3+v2.patch ___ Python tracker ___ _

[issue16197] Several small errors in winreg documentation

Zachary Ware added the comment: The thought on consolidating is to match Doc/library/msvcrt.rst which does the same thing. Also, when I started reading this page shortly before opening this issue, I was reading most of the page at once and was frankly pretty annoyed by seeing the same notice

[issue16197] Several small errors in winreg documentation

Andrew Svetlov added the comment: Not sure consolidating is good idea, ok with other changes. -- nosy: +asvetlov ___ Python tracker ___ __

[issue16197] Several small errors in winreg documentation

Zachary Ware added the comment: Thanks for the commit! 3.2 looks good now. 3.3 and default still need a little work, though; the docstrings still say "WindowsError" instead of "OSError" and the docs say "a OSError" instead of "an OSError". The attached patch cleans up both issues, as well as

[issue16197] Several small errors in winreg documentation

Brian Curtin added the comment: Pushed fixes for 3.2+ Thanks for the patch! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue16197] Several small errors in winreg documentation

Roundup Robot added the comment: New changeset b9e14b89199b by Brian Curtin in branch '3.2': Fix #16197. Update docstrings and documentation to match winreg code. http://hg.python.org/cpython/rev/b9e14b89199b -- nosy: +python-dev ___ Python tracker <

[issue16197] Several small errors in winreg documentation

Zachary Ware added the comment: That's what I figured, so that's what I did in the patch; but I've also seen cases in Python where prior documentation has dictated how the code should work. Thanks for the confirmation. -- ___ Python tracker

[issue16197] Several small errors in winreg documentation

Brian Curtin added the comment: Docs should match code. If we did it the other way around we'd probably break something. Thanks for looking into this. I've been busy the last few days but I will get to the review and application of the patch very soon. --

[issue16197] Several small errors in winreg documentation

Zachary Ware added the comment: It occurs to me that I should have asked; should the documentation be changed to match the code, or the code to match the documentation (with regards to the default argument to the access parameter in a few functions)? -- ___

[issue16197] Several small errors in winreg documentation

Zachary Ware added the comment: Here's the patch against 3.2, hopefully I caught everything I meant to :) Unfortunately, I can't build Python or the docs on this machine, so I can't guarantee I didn't break anything. I tried to be careful though, especially with changing linebreaks in the doc

[issue16197] Several small errors in winreg documentation

Zachary Ware added the comment: Okie doke. I'll try to have a patch ready for review later this afternoon. -- ___ Python tracker ___

[issue16197] Several small errors in winreg documentation

Brian Curtin added the comment: The patch looks alright, but I would remove the lining up of definitions. It's probably easiest to do a patch against 3.2 and I can handle the porting on commit. -- assignee: docs@python -> brian.curtin components: +Windows type: -> behavior ___

[issue16197] Several small errors in winreg documentation

New submission from Zachary Ware: There are several small inconsistencies in the winreg module documentation (docstrings and winreg.rst). Mostly these are discrepancies between "res" and "reserved", "sam" and "access", and whether or not those two are keyword arguments, but there are some oth