[issue15977] Memory leak in _ssl.c

2012-09-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4cf53684e14e by Christian Heimes in branch 'default': Issue #15977: Fix memory leak in Modules/_ssl.c when the function _set_npn_protocols() is called multiple times http://hg.python.org/cpython/rev/4cf53684e14e --

[issue15977] Memory leak in _ssl.c

2012-09-21 Thread Georg Brandl
Georg Brandl added the comment: Picked. -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue15977] Memory leak in _ssl.c

2012-09-20 Thread Christian Heimes
Christian Heimes added the comment: Georg, here is another candidate for the new release candidate. Daniel, two equal patches are good enough as a patch review. The fix is simple and straight forward, too. Thanks for your report! -- assignee: -> georg.brandl nosy: +georg.brandl resolu

[issue15977] Memory leak in _ssl.c

2012-09-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2bdc8c8ea42e by Christian Heimes in branch 'default': Issue #15977: Fix memory leak in Modules/_ssl.c when the function _set_npn_protocols() is called multiple times http://hg.python.org/cpython/rev/2bdc8c8ea42e -- nosy: +python-dev __

[issue15977] Memory leak in _ssl.c

2012-09-20 Thread Daniel Sommermann
Daniel Sommermann added the comment: This patch looks good to me (it's exactly how I fixed it in my local build), although I'm not sure how to approve your patch so you can push it to the upstream. -- ___ Python tracker

[issue15977] Memory leak in _ssl.c

2012-09-19 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- stage: -> patch review type: -> resource usage ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue15977] Memory leak in _ssl.c

2012-09-19 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea stage: patch review -> type: resource usage -> ___ Python tracker ___ ___ Python-bugs-li

[issue15977] Memory leak in _ssl.c

2012-09-19 Thread Christian Heimes
Christian Heimes added the comment: You are right. I did some testing and the function indeed leaks memory. The attached patch fixes the issue for me. -- keywords: +patch nosy: +christian.heimes stage: -> patch review type: -> resource usage Added file: http://bugs.python.org/file2722

[issue15977] Memory leak in _ssl.c

2012-09-19 Thread Daniel Sommermann
New submission from Daniel Sommermann: I noticed that the function _set_npn_protocols() has the following line: self->npn_protocols = PyMem_Malloc(protos.len); There is no check to see if self->npn_protocols is already allocated. Thus, multiple calls to _set_npn_protocols() will leak memory. T