[issue15973] Segmentation fault on timezone comparison

Roundup Robot added the comment: New changeset ec77f8fb9958 by Georg Brandl in branch 'default': Closes #15973: fix a segmentation fault when comparing timezone objects. http://hg.python.org/cpython/rev/ec77f8fb9958 -- ___ Python tracker

[issue15973] Segmentation fault on timezone comparison

Georg Brandl added the comment: Done as ec77f8fb9958. -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue15973] Segmentation fault on timezone comparison

Stefan Krah added the comment: This one: 63cb0a642c84 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue15973] Segmentation fault on timezone comparison

Georg Brandl added the comment: Which commit(s) do I have to pick? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue15973] Segmentation fault on timezone comparison

Roundup Robot added the comment: New changeset f17f67f0ec4b by Alexander Belopolsky in branch '3.2': Issue #15973: fixed 3.2 backport. http://hg.python.org/cpython/rev/f17f67f0ec4b -- ___ Python tracker ___

[issue15973] Segmentation fault on timezone comparison

STINNER Victor added the comment: Your change does not compile on Windows: _datetimemodule.c ..\Modules\_datetimemodule.c(3247) : error C2065: 'Py_RETURN_NOTIMPLEMENTED' : undeclared identifier http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.2/builds/194/steps/compile/logs/s

[issue15973] Segmentation fault on timezone comparison

Alexander Belopolsky added the comment: Leeaving the issue open in case it will go to 3.3.0. Reassigning to the RM. -- assignee: belopolsky -> georg.brandl resolution: -> fixed stage: commit review -> committed/rejected ___ Python tracker

[issue15973] Segmentation fault on timezone comparison

Roundup Robot added the comment: New changeset 9fba12ceb2fd by Alexander Belopolsky in branch '3.2': Issue #15973: Fixed segmentation fault on timezone comparison to other types. http://hg.python.org/cpython/rev/9fba12ceb2fd -- nosy: +python-dev ___ P

[issue15973] Segmentation fault on timezone comparison

Stefan Krah added the comment: Looks good. It would be nice to have this in 3.3.0. There are a couple of blockers open, so perhaps this could go in, too. Georg, are we going to have an rc3 anyway? -- nosy: +georg.brandl ___ Python tracker

[issue15973] Segmentation fault on timezone comparison

Alexander Belopolsky added the comment: > Alexander, did you send a contributor agreement? At least twice. :-) -- keywords: +patch priority: normal -> high stage: needs patch -> commit review Added file: http://bugs.python.org/file27234/issue15973.diff _

[issue15973] Segmentation fault on timezone comparison

Jesús Cea Avión added the comment: Alexander, did you send a contributor agreement?. I don't see it in the tracker :-?? -- ___ Python tracker ___ ___

[issue15973] Segmentation fault on timezone comparison

Alexander Belopolsky added the comment: > What about datetime subclasses? Do you mean timezone subclasses? Timezone type is not subclassable, but we should probably support comparison with any tzinfo subclass. I'll add this logic, but arguably that would be a new feature. -- __

[issue15973] Segmentation fault on timezone comparison

Jesús Cea Avión added the comment: What about datetime subclasses? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue15973] Segmentation fault on timezone comparison

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15973] Segmentation fault on timezone comparison

Benjamin Peterson added the comment: Hopefully, there will be some more braces, though. :) -- nosy: +benjamin.peterson ___ Python tracker ___

[issue15973] Segmentation fault on timezone comparison

Alexander Belopolsky added the comment: I think the following simple patch should do the trick. I'll add some tests and commit. Should this get in 3.3.0? diff -r 19c74cadea95 Modules/_datetimemodule.c --- a/Modules/_datetimemodule.c Wed Sep 19 08:25:01 2012 +0300 +++ b/Modules/_datetimemodu

[issue15973] Segmentation fault on timezone comparison

R. David Murray added the comment: On linux it segfaults for me in the debug interpreter. On default tip. -- nosy: +r.david.murray ___ Python tracker ___ ___

[issue15973] Segmentation fault on timezone comparison

Stefan Krah added the comment: The segfault does not occur in a debug build. The stack trace suggests that timezone_richcompare() accesses other->offset of the None object: (gdb) f 2 #2 0x0041d4e9 in do_richcompare (v=None, w=, op=) at Objects/object.c:563 563 res = (*f

[issue15973] Segmentation fault on timezone comparison

Alexander Belopolsky added the comment: I cannot reproduce on a Mac with py3k tip. Python 3.3.0rc2+ (default:19c74cadea95, Sep 19 2012, 14:39:07) [GCC 4.2.1 Compatible Apple Clang 3.1 (tags/Apple/clang-318.0.61)] on darwin Type "help", "copyright", "credits" or "license" for more information. >

[issue15973] Segmentation fault on timezone comparison

John Taylor added the comment: Crashes Python 3.2.3 and Python 3.3.0rc2 on Windows 7 as well. -- nosy: +jftuga ___ Python tracker ___

[issue15973] Segmentation fault on timezone comparison

Changes by Alexander Belopolsky : -- assignee: ronaldoussoren -> belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue15973] Segmentation fault on timezone comparison

Stefan Krah added the comment: Reproducible also on Linux with Python 3.3. -- components: +Extension Modules -Macintosh nosy: +belopolsky, skrah stage: -> needs patch versions: +Python 3.3 ___ Python tracker _

[issue15973] Segmentation fault on timezone comparison

New submission from Lance Helsten: In the 3.2.3 interpreter execute the following line: `None == datetime.timezone(datetime.timedelta())` The interpreter will crash with a `Segmentation fault: 11`. -- assignee: ronaldoussoren components: Macintosh files: CoreDump.txt messages: 170732